Skip to content

Implement file deletion for CreateTree #1372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 10, 2020
Merged

Implement file deletion for CreateTree #1372

merged 1 commit into from
Jan 10, 2020

Conversation

gmlewis
Copy link
Collaborator

@gmlewis gmlewis commented Jan 10, 2020

Fixes #1371.

@googlebot googlebot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Jan 10, 2020
@gmlewis gmlewis requested a review from gauntface January 10, 2020 01:19
@gmlewis
Copy link
Collaborator Author

gmlewis commented Jan 10, 2020 •
edited
Loading

Awaiting code review and LGTM before merging.

wesleimp
wesleimp approved these changes Jan 10, 2020
View reviewed changes
Copy link
Collaborator

@wesleimp wesleimp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@gmlewis
Copy link
Collaborator Author

gmlewis commented Jan 10, 2020

Thank you, @wesleimp !
Merging.

@gmlewis gmlewis merged commit ab35a47 into google:master Jan 10, 2020
@gmlewis gmlewis deleted the i1371-create-tree-delete-file branch January 10, 2020 12:31
@gmlewis gmlewis mentioned this pull request Jan 10, 2020
Closed
n1lesh pushed a commit to n1lesh/go-github that referenced this pull request Oct 2, 2020
@gmlewis
Implement file deletion for CreateTree (google#1372)
9c4ac88
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gauntface gauntface Awaiting requested review from gauntface

1 more reviewer

@wesleimp wesleimp wesleimp approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The Tree API does not allow for file deletion
3 participants
@gmlewis @wesleimp @googlebot