fix!: Return RepositoryAttachment from GetRepositoriesForCodeSecurityConfiguration
#3707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmlewis
approved these changes
Sep 18, 2025
Collaborator
gmlewis
left a comment
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @ericmort!
LGTM.
Please note that I still don't have write access to this repo, but figure I might as well attempt to catch up on my code reviews (which I usually allow the linter to process first... ah, well).
NOTES TO SELF:
- Add to the description:
BREAKING CHANGE:GetRepositoriesForCodeSecurityConfigurationnow returnsRepositoryAttachmentinstead ofRepository. - Add Breaking API label
- Change PR title:
fix!: ReturnRepositoryAttachmentfromGetRepositoriesForCodeSecurityConfiguration
Collaborator
|
Fixes: #3217. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3707 +/- ##
=======================================
Coverage 91.11% 91.11%
=======================================
Files 187 187
Lines 16684 16686 +2
=======================================
+ Hits 15202 15204 +2
Misses 1295 1295
Partials 187 187 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gmlewis
added
NeedsReview
gmlewis
changed the title
RepositoryAttachment from GetRepositoriesForCodeSecurityConfiguration
Collaborator
|
@ericmort - would you mind resolving the conflicts in this PR or would you like me to do that? |
Contributor
Author
|
@gmlewis I resolved it now |
Collaborator
…t/go-github into fix-json-unmarshal-error
Collaborator
|
Thank you, @ericmort! cc: @stevehipwell |
Collaborator
|
Thank you, @stevehipwell! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: GetRepositoriesForCodeSecurityConfiguration now returns RepositoryAttachment instead of Repository.
Adds type RepositoryAttachment for GetRepositoriesForCodeSecurityConfiguration
Fixes unmarshal error in GetRepositoriesForCodeSecurityConfiguration, as described in #3217.
(I submitted the PR under my corporate GitHub user, but I could not get a proper google/CLA so using my personal user.)