Skip to content

Conversation

gmlewis
Copy link
Collaborator

@gmlewis gmlewis commented Mar 13, 2020

Once #1451 is merged, we are ready for a major release with many breaking changes.
This PR can be merged after #1451, and then a new v30.0.0 release can be created and tagged.

@googlebot googlebot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Mar 13, 2020
@codecov
Copy link

codecov bot commented Mar 13, 2020

Codecov Report

Merging #1456 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1456   +/-   ##
=======================================
  Coverage   68.16%   68.16%           
=======================================
  Files          94       94           
  Lines        8419     8419           
=======================================
  Hits         5739     5739           
  Misses       1819     1819           
  Partials      861      861

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5d8dd6...caab839. Read the comment docs.

Copy link
Collaborator

@wesleimp wesleimp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

@joebowbeer
Copy link

LGTM

@gmlewis
Copy link
Collaborator Author

gmlewis commented Mar 18, 2020

Thank you, @wesleimp and @joebowbeer!
Merging and then releasing v30.0.0.

@gmlewis gmlewis merged commit f5442b7 into google:master Mar 18, 2020
@gmlewis gmlewis deleted the release-v30 branch March 18, 2020 13:31
sprsld pushed a commit to sprsld/go-github that referenced this pull request Mar 24, 2020
n1lesh pushed a commit to n1lesh/go-github that referenced this pull request Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants