Skip to content

Add support for pull_request_target webhook event #1844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 8, 2021
Merged

Add support for pull_request_target webhook event #1844

merged 1 commit into from
Apr 8, 2021

Conversation

ganboonhong
Copy link
Contributor

Fixes #1834.

@google-cla google-cla bot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Apr 3, 2021
@codecov
Copy link

codecov bot commented Apr 3, 2021

Codecov Report

Merging #1844 (e5a260a) into master (221a3b6) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1844      +/-   ##
==========================================
+ Coverage   97.56%   97.59%   +0.03%     
==========================================
  Files         104      104              
  Lines        6602     6617      +15     
==========================================
+ Hits         6441     6458      +17     
+ Misses         87       86       -1     
+ Partials       74       73       -1
Impacted Files Coverage Δ
github/event_types.go 100.00% <ø> (ø)
github/messages.go 96.87% <ø> (ø)
github/event.go 100.00% <100.00%> (ø)
github/actions_secrets.go 100.00% <0.00%> (ø)
github/apps_marketplace.go 88.23% <0.00%> (+3.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 221a3b6...e5a260a. Read the comment docs.

gmlewis
gmlewis approved these changes Apr 3, 2021
View reviewed changes
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @ganboonhong !
LGTM.

Awaiting second LGTM before merging.

@gmlewis gmlewis requested a review from wesleimp April 3, 2021 17:17
wesleimp
wesleimp approved these changes Apr 8, 2021
View reviewed changes
Copy link
Collaborator

@wesleimp wesleimp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💙

@gmlewis
Copy link
Collaborator

gmlewis commented Apr 8, 2021

Thank you, @wesleimp !
Merging.

@gmlewis gmlewis merged commit 3557c20 into google:master Apr 8, 2021
@ganboonhong ganboonhong deleted the support-pull-request-target branch April 8, 2021 14:35
@gmlewis gmlewis mentioned this pull request Apr 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmlewis gmlewis gmlewis approved these changes

+1 more reviewer

@wesleimp wesleimp wesleimp approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for pull_request_target webhook event
3 participants
@ganboonhong @gmlewis @wesleimp