Add Support For Millisecond Timestamps #1850
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
|
Missed the enterprise_audit_log tests, fixing... |
Codecov Report
@@ Coverage Diff @@
## master #1850 +/- ##
=======================================
Coverage 97.59% 97.59%
=======================================
Files 104 104
Lines 6615 6617 +2
=======================================
+ Hits 6456 6458 +2
Misses 86 86
Partials 73 73
Continue to review full report at Codecov.
|
gmlewis
requested changes
Apr 6, 2021
The GitHub Audit Log API introduced timestamps with millisecond granularity. We add support for these timestamps by first parsing the timestamp into a Unix timestamp and then checking to see if the generated timestamp is in the future. If the timestamp is in the future we re-parse it as a Unix timestamp in Milliseconds. Signed-off-by: Brett Logan <lindluni@github.com>
gmlewis
reviewed
Apr 6, 2021
Signed-off-by: Brett Logan <lindluni@github.com>
|
Thank you, @wesleimp ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GitHub Audit Log API introduced timestamps with millisecond granularity. We add support for these timestamps by first parsing the timestamp into a Unix timestamp and then checking to see if the generated timestamp is in the future. If the timestamp is in the future we re-parse it as a Unix timestamp in Milliseconds.
Tests were added to ensure that when the timestamp is 1 millisecond off that the granularity of the timestamp is preserved by milliseconds correctly being parsed.
Closes #1849
Signed-off-by: Brett Logan lindluni@github.com