Skip to content

Conversation

g4s8
Copy link
Contributor

@g4s8 g4s8 commented Jul 7, 2021

Fixes #1945 - added a new field for Protection struct
to parse required_conversation_resolution JSON field
from API response for branch protection rules.
Updated test.

@google-cla google-cla bot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Jul 7, 2021
@gmlewis gmlewis changed the title Added RequiredConversationResolution protection field Add RequiredConversationResolution protection field Jul 7, 2021
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @g4s8 !
Just a couple minor tweaks, please, for documentation purposes. (Note the ending period.)

@codecov
Copy link

codecov bot commented Jul 7, 2021

Codecov Report

Merging #1946 (6a69124) into master (05e95d3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1946   +/-   ##
=======================================
  Coverage   97.65%   97.65%           
=======================================
  Files         105      105           
  Lines        6786     6786           
=======================================
  Hits         6627     6627           
  Misses         86       86           
  Partials       73       73           
Impacted Files Coverage Δ
github/repos.go 98.70% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05e95d3...6a69124. Read the comment docs.

Fixes #1945 - added a new field for `Protection` struct
to parse `required_conversation_resolution` JSON field
from API response for branch protection rules.
Updated test.
@g4s8
Copy link
Contributor Author

g4s8 commented Jul 7, 2021

@gmlewis thanks, fixed in 6a69124

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @g4s8 !
LGTM.

Awaiting second LGTM before merging.

@gmlewis gmlewis requested a review from wesleimp July 7, 2021 16:46
Copy link

@Parker77 Parker77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@gmlewis gmlewis merged commit be31e40 into google:master Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missed required_conversation_resolution field in branch protection rules
3 participants