Skip to content

Conversation

dazuma
Copy link
Contributor

@dazuma dazuma commented Aug 22, 2018

It looks like the logging gem used to be in the bundle implicitly due to a transitive dependency, but has been removed. This is why the tests have been breaking. Adding it explicitly because the spec helper requires it.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 22, 2018
@dazuma dazuma requested a review from a team August 22, 2018 19:52
@coveralls
Copy link

coveralls commented Aug 22, 2018

Coverage Status

Coverage increased (+0.07%) to 96.064% when pulling b33c970 on dazuma:logging-fix into 24be95a on google:master.

@dazuma
Copy link
Contributor Author

dazuma commented Aug 22, 2018

Also made two more changes:

  • Removed two enormous puts calls that were overwhelming the travis logs and making test output useless.
  • Added the new Signet::RemoteServerError (see Handle 5xx errors with RemoteServerError signet#100) to the list of retriable auth errors, to make HttpCommand tests pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants