Skip to content

Conversation

ylecuyer
Copy link
Contributor

Similar to #707

As asked by @TheRoyalTnetennba in googleapis/signet#101

This PR adds the new UnexpectedStatusError

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 31, 2018
@coveralls
Copy link

Coverage Status

Coverage decreased (-13.4%) to 82.653% when pulling 60322d1 on ylecuyer:add-unexpected-error-signet into ae3634f on google:master.

@ylecuyer
Copy link
Contributor Author

@TheRoyalTnetennba can this be merged ?

@grant
Copy link
Contributor

grant commented Sep 19, 2018

The Travis build needs to pass before merging.
I've restarted the build in case it's failing randomly.
https://travis-ci.org/googleapis/google-api-ruby-client/builds/423180518

@ylecuyer
Copy link
Contributor Author

Tests won't pass until googleapis/signet#101 gets merged and is available.

What should I do then ?

@TheRoyalTnetennba
Copy link
Contributor

Can you update the gemspec entry for the dependency on signet to be ~> 0.10?

@ylecuyer
Copy link
Contributor Author

done

@TheRoyalTnetennba TheRoyalTnetennba merged commit 224497c into googleapis:master Sep 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants