-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JPMS module name #2961
Add JPMS module name #2961
Conversation
Move to the correct pom.xml
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
@jodastephen By my understanding, if you just sign the Google CLA, then that should be enough to allow this PR to be considered for merging. |
I signed it! |
CLAs look good, thanks! |
Thanks. Any opinion on whether we should set an |
As it stands, I don't think its clear how test libraries will operate with modules - I suspect that modules don't really apply there. If runtime code might depend on testlib then of course it should have a module name. |
Thanks. |
Move to the correct pom.xml.
Fixes #2920
Commit 9feba7c of #2846 placed the
Automatic-Module-Name
declaration in the wrongpom.xml
. As such, Guava still isn't a valid module, which blocks a whole heap of projects from declaringmodule-info.java
.Feel free to make a separate change rather than merging this PR to satisfy any IP rules.