Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JPMS module name #2961

Closed
wants to merge 1 commit into from
Closed

Conversation

jodastephen
Copy link
Contributor

Move to the correct pom.xml.

Fixes #2920
Commit 9feba7c of #2846 placed the Automatic-Module-Name declaration in the wrongpom.xml. As such, Guava still isn't a valid module, which blocks a whole heap of projects from declaring module-info.java.

Feel free to make a separate change rather than merging this PR to satisfy any IP rules.

Move to the correct pom.xml
@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@jbduncan
Copy link
Contributor

jbduncan commented Oct 9, 2017

@jodastephen By my understanding, if you just sign the Google CLA, then that should be enough to allow this PR to be considered for merging.

@jodastephen
Copy link
Contributor Author

I signed it!

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Oct 9, 2017
@cpovirk
Copy link
Member

cpovirk commented Oct 9, 2017

Thanks. Any opinion on whether we should set an Automatic-Module-Name for our guava-testlib test utilities? They're much, much less heavily used, but maybe we might as well? Or maybe it's not worth worrying about modules for code that runs only in tests, since it sounds like there might not be a good story yet for running most tests with modules on?

@jodastephen
Copy link
Contributor Author

As it stands, I don't think its clear how test libraries will operate with modules - I suspect that modules don't really apply there. If runtime code might depend on testlib then of course it should have a module name.

@cpovirk
Copy link
Member

cpovirk commented Oct 9, 2017

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants