-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add step transition animation in ABR setup #7292
Labels
Module: AdSense
Google AdSense module related issues
P2
Low priority
Type: Enhancement
Improvement of an existing feature
Comments
mxbclang
added
P2
Low priority
Type: Enhancement
Improvement of an existing feature
labels
Jul 12, 2023
18 tasks
IB ✅ |
techanvil
added a commit
that referenced
this issue
Nov 22, 2023
…tion Implement `Stepper` transition
QA Update: ❌@nfmohit I have two observations to highlight.
The issue reported above is not a regression, so I will create a new ticket for this.
The screencast below showcases both issues. abr.mp4 |
18 tasks
tofumatt
added a commit
that referenced
this issue
Nov 24, 2023
Fix `AdBlockingRecoveryApp` setup status unresolved issue
QA Update ✅
Recording.670.mp4Recording.672.mp4 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Module: AdSense
Google AdSense module related issues
P2
Low priority
Type: Enhancement
Improvement of an existing feature
Feature Description
As reported by @kuasha420 in Bug Bash:
There should be a "subtle" transition animation when the step is changed from 1 to 2, currently it feels abrupt.
See https://mui.com/material-ui/react-stepper/#vertical-stepper for an example of it.
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Stepper
component should have a transitional animation when changing the current step. This should be modelled on the MUI vertical stepper linked in the description - the new step should slide up into view, replacing the previous step.Stepper
component in the plugin.Implementation Brief
As discussed here it doesn't seem to be possible to transition an HTML element from zero height to the height of its content using CSS only. Therefore we take an approach using JS to set the height to transition to when setting a step to be active. Furthermore as discussed here, we take the approach of setting the height to
0
for a non-active step, which means we can determine its content height by using itsscrollHeight
property.Step
component so it unconditionally renders its content, adding a CSS class to the content div for theactive
status.visibility: hidden
to the non-active steps' content in order to hide their hidden content from screen readers and prevent it from being tabbed into.Test Coverage
Stepper
tests to accommodate these changes.QA Brief
Changelog entry
The text was updated successfully, but these errors were encountered: