Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Stepper transition #7901

Merged
merged 7 commits into from
Nov 22, 2023
Merged

Conversation

nfmohit
Copy link
Collaborator

@nfmohit nfmohit commented Nov 21, 2023

Summary

Addresses issue:

Relevant technical choices

This PR implements a transition to the Stepper component as requested in #7292.

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 5.2 and PHP 5.6.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

Copy link

github-actions bot commented Nov 21, 2023

Build files for ba03aba have been deleted.

Copy link

github-actions bot commented Nov 21, 2023

Size Change: -226 B (0%)

Total Size: 1.42 MB

Filename Size Change
./dist/assets/css/googlesitekit-admin-css-********************.min.css 51.9 kB +85 B (0%)
./dist/assets/js/googlesitekit-activation-********************.js 22.6 kB +1 B (0%)
./dist/assets/js/googlesitekit-ad-blocking-recovery-********************.js 54.6 kB -13 B (0%)
./dist/assets/js/googlesitekit-adminbar-********************.js 33.4 kB -23 B (0%)
./dist/assets/js/googlesitekit-api-********************.js 9.95 kB +1 B (0%)
./dist/assets/js/googlesitekit-components-gm2-********************.js 5.72 kB +2 B (0%)
./dist/assets/js/googlesitekit-components-gm3-********************.js 10 kB -1 B (0%)
./dist/assets/js/googlesitekit-data-********************.js 2.18 kB -2 B (0%)
./dist/assets/js/googlesitekit-datastore-site-********************.js 18.2 kB -1 B (0%)
./dist/assets/js/googlesitekit-datastore-user-********************.js 24.9 kB -23 B (0%)
./dist/assets/js/googlesitekit-entity-dashboard-********************.js 68.4 kB -38 B (0%)
./dist/assets/js/googlesitekit-main-dashboard-********************.js 85.5 kB -30 B (0%)
./dist/assets/js/googlesitekit-modules-adsense-********************.js 106 kB -40 B (0%)
./dist/assets/js/googlesitekit-modules-analytics-********************.js 84.7 kB -25 B (0%)
./dist/assets/js/googlesitekit-modules-analytics-4-********************.js 77 kB -21 B (0%)
./dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js 21.6 kB -4 B (0%)
./dist/assets/js/googlesitekit-modules-search-console-********************.js 64.2 kB -19 B (0%)
./dist/assets/js/googlesitekit-modules-tagmanager-********************.js 31.2 kB +4 B (0%)
./dist/assets/js/googlesitekit-settings-********************.js 49.4 kB -25 B (0%)
./dist/assets/js/googlesitekit-splash-********************.js 65.8 kB -2 B (0%)
./dist/assets/js/googlesitekit-user-input-********************.js 41.3 kB -1 B (0%)
./dist/assets/js/googlesitekit-vendor-********************.js 316 kB +3 B (0%)
./dist/assets/js/googlesitekit-widgets-********************.js 32.2 kB -38 B (0%)
./dist/assets/js/googlesitekit-wp-dashboard-********************.js 61.7 kB -16 B (0%)
ℹ️ View Unchanged
Filename Size
./dist/assets/css/googlesitekit-adminbar-css-********************.min.css 11.4 kB
./dist/assets/css/googlesitekit-wp-dashboard-css-********************.min.css 7.58 kB
./dist/assets/js/29-********************.js 2.8 kB
./dist/assets/js/30-********************.js 2.28 kB
./dist/assets/js/31-********************.js 3.72 kB
./dist/assets/js/32-********************.js 929 B
./dist/assets/js/33-********************.js 888 B
./dist/assets/js/34-********************.js 3.12 kB
./dist/assets/js/analytics-advanced-tracking-********************.js 769 B
./dist/assets/js/googlesitekit-datastore-forms-********************.js 9.17 kB
./dist/assets/js/googlesitekit-datastore-location-********************.js 2.09 kB
./dist/assets/js/googlesitekit-datastore-ui-********************.js 9.28 kB
./dist/assets/js/googlesitekit-i18n-********************.js 3.92 kB
./dist/assets/js/googlesitekit-modules-********************.js 21.4 kB
./dist/assets/js/googlesitekit-polyfills-********************.js 380 B
./dist/assets/js/runtime-********************.js 1.29 kB

compressed-size-action

Copy link
Collaborator

@techanvil techanvil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great work @nfmohit!

.googlesitekit-stepper__step-content-container {
display: grid;
grid-template-rows: 0fr;
transition: grid-template-rows $t-default ease-in-out;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! I totally didn't spot the possibility of transitioning grid-template-rows while drafting the IB. Makes for a pure CSS approach, which is great to see.

@techanvil techanvil merged commit bff8988 into develop Nov 22, 2023
20 checks passed
@techanvil techanvil deleted the enhancement/#7292-stepper-transition branch November 22, 2023 15:12
@techanvil techanvil mentioned this pull request Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants