-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Stepper
transition
#7901
Conversation
Build files for ba03aba have been deleted. |
Size Change: -226 B (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great work @nfmohit!
.googlesitekit-stepper__step-content-container { | ||
display: grid; | ||
grid-template-rows: 0fr; | ||
transition: grid-template-rows $t-default ease-in-out; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! I totally didn't spot the possibility of transitioning grid-template-rows
while drafting the IB. Makes for a pure CSS approach, which is great to see.
Summary
Addresses issue:
Relevant technical choices
This PR implements a transition to the Stepper component as requested in #7292.
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist