Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub release? #64

Closed
OmgImAlexis opened this issue May 13, 2021 · 10 comments
Closed

Add GitHub release? #64

OmgImAlexis opened this issue May 13, 2021 · 10 comments

Comments

@OmgImAlexis
Copy link

It'd make it easier to find the current version, etc. if GitHub release were to be used.

Even better would be to add an automated GitHub actions workflow to handle this.

@Nixinova
Copy link
Contributor

Was just about to suggest this, the project has no tags and no changelog currently.

@antonmedv
Copy link
Collaborator

Can somebody implement it?

@Nixinova
Copy link
Contributor

Only those with write access can create tags and releases

@antongolub
Copy link
Collaborator

antongolub commented May 13, 2021

@antonmedv, what's about semantic-release? I can add if appropriate.

  • conventional commits
  • auto-generated changelog
  • release commits and tags
  • npm publishing

@FarazzShaikh
Copy link

@antongolub are you still working on this? I too have an GitHub Actions setup with those features I can quickly add.

@antonmedv
Copy link
Collaborator

Sure, send a PR.

@antongolub
Copy link
Collaborator

@FarazzShaikh, @antonmedv,

Is it ok, that release action would be added before autotests? #69

@FarazzShaikh
Copy link

@antongolub i think it would be better if the release is made only after tests pass, what do you think?

@antonmedv
Copy link
Collaborator

Just add npm test before.

antongolub added a commit to antongolub/zx that referenced this issue May 18, 2021
antongolub added a commit to antongolub/zx that referenced this issue May 18, 2021
@antonmedv
Copy link
Collaborator

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants