fix: Deprecating generic load methods and adding warnings on few cred types #1812
+163
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sai-sunder-s
commented
Sep 24, 2025
sai-sunder-s
force-pushed
the
deprecategenericload
branch
2 times, most recently
from
98b8e0b to
3078bb2
Compare
chalmerlowe
previously approved these changes
Sep 25, 2025
sai-sunder-s
force-pushed
the
deprecategenericload
branch
from
3e75f37 to
e7fdbf9
Compare
sai-sunder-s
force-pushed
the
deprecategenericload
branch
from
e76e2fa to
45d61e2
Compare
parthea
reviewed
Sep 26, 2025
sai-sunder-s
force-pushed
the
deprecategenericload
branch
from
4d7442f to
0c60cbd
Compare
parthea
previously approved these changes
Sep 26, 2025
sai-sunder-s
force-pushed
the
deprecategenericload
branch
from
163988d to
a4bdf8e
Compare
parthea
approved these changes
Sep 29, 2025
This was referenced Sep 30, 2025
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deprecates methods that load any credential type from a given json or file, specifically
load_credentials_from_fileandload_credentials_from_dict. Instead, it is recommended to use the load methods specific to a credential type. It is recommended to perform validation when a credential config is obtained from external sources. Please read the deprecation warning message and the warnings on appropriate credential types for the full context.BEGIN_COMMIT_OVERRIDE
fix: Deprecating load_credentials_from_file
fix: Deprecating load_credentials_from_dict
END_COMMIT_OVERRIDE