Skip to content

fix: deprecate credentials_file argument #841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 1, 2025
Merged

fix: deprecate credentials_file argument #841

merged 4 commits into from
Oct 1, 2025
+149 −33

Conversation

parthea
Copy link
Collaborator

@parthea parthea commented Sep 30, 2025

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Sep 30, 2025
sai-sunder-s
sai-sunder-s reviewed Sep 30, 2025
View reviewed changes
@parthea parthea force-pushed the deprecate-credentials-file branch from 4dd29b9 to bdc95f3 Compare September 30, 2025 18:40
@parthea parthea force-pushed the deprecate-credentials-file branch from bdc95f3 to 1ba2168 Compare September 30, 2025 18:55
@parthea parthea marked this pull request as ready for review September 30, 2025 18:57
@parthea parthea requested review from a team as code owners September 30, 2025 18:57
sai-sunder-s
sai-sunder-s previously approved these changes Sep 30, 2025
View reviewed changes
chalmerlowe
chalmerlowe approved these changes Oct 1, 2025
View reviewed changes
Copy link

@chalmerlowe chalmerlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chalmerlowe chalmerlowe merged commit 324eb74 into main Oct 1, 2025
49 checks passed
@chalmerlowe chalmerlowe deleted the deprecate-credentials-file branch October 1, 2025 09:44
@release-please release-please bot mentioned this pull request Oct 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalmerlowe chalmerlowe chalmerlowe approved these changes

@sai-sunder-s sai-sunder-s sai-sunder-s left review comments

Assignees

@vchudnov-g vchudnov-g

Labels
size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@parthea @sai-sunder-s @chalmerlowe @vchudnov-g