Skip to content

fix: updated modack batching behavior #1139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 18, 2022
Merged

fix: updated modack batching behavior #1139

merged 1 commit into from
May 18, 2022

Conversation

@mmicatka
Copy link
Contributor

@mmicatka mmicatka commented May 18, 2022

Modack batching fix for LTS 1.117,x

  • Moved the ackIdsInRequest for modack operations to the correct place.
  • Wrote tests around expected batching/partition behavior to verify change works as expected

Fixes #1126 which was due to incorrect partitioning of ackIds for ModifyAckDeadlineRequest

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: pubsub Issues related to the googleapis/java-pubsub API. labels May 18, 2022
@mmicatka mmicatka marked this pull request as ready for review May 18, 2022 20:57
@mmicatka mmicatka requested a review from a team as a code owner May 18, 2022 20:57
@mmicatka mmicatka merged commit 8a8c537 into 1.117.x May 18, 2022
@mmicatka mmicatka deleted the modack_batch_fix branch May 18, 2022 21:02
@release-please release-please bot mentioned this pull request May 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@hannahrogers-google hannahrogers-google hannahrogers-google approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: pubsub Issues related to the googleapis/java-pubsub API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mmicatka @hannahrogers-google