fix: temporarily disables emulator tests #693
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Temporarily disables tests that are not working with the emulator.
product-auto-label
bot
added
the
api: spanner
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #693 +/- ##
=========================================
Coverage 84.12% 84.12%
Complexity 2511 2511
=========================================
Files 142 142
Lines 13911 13911
Branches 1323 1323
=========================================
Hits 11702 11702
+ Misses 1664 1663 -1
- Partials 545 546 +1
Continue to review full report at Codecov.
|
|
@thiagotnunes Good catch. I looked into this a little bit, and there was a fundamental problem with that test case for both the emulator and real Cloud Spanner. The reason that it could go unnoticed for some time was that the test class was not annotated with a |
|
Thanks for that @olavloite |
ansh0l
pushed a commit
to ansh0l/java-spanner
that referenced
this pull request
Nov 10, 2022
This is an auto-generated regeneration of the .pb.go files by cloud.google.com/go/internal/gapicgen. Once this PR is submitted, genbot will update the corresponding PR to depend on the newer version of go-genproto, and assign reviewers. Whilst this or any regen PR is open in go-genproto, genbot will not create any more regeneration PRs. If all regen PRs are closed, gapicgen will create a new set of regeneration PRs once per night. If you have been assigned to review this PR, please: - Ensure that CI is passing. If it's failing, it requires your manual attention. - Approve and submit this PR if you believe it's ready to ship. That will prompt genbot to assign reviewers to the google-cloud-go PR. Corresponding google-cloud-go PR: googleapis/google-cloud-go#4958 Changes: chore: regenerate API index Source-Link: googleapis/googleapis@2974b81 feat: add Similarity to explanation in aiplatform v1beta1 feat: add EncryptionSpec to featurestore in aiplatform v1beta1 feat: add PipelineTaskStatus to pipeline_job in aiplatform v1beta1 feat: add BatchReadTensorboardTimeSeriesData to tensorboard_service in aiplatform v1beta1 feat: add enable_monitoring_pipeline_logs to model_deployment_monitoring_job in aiplatform v1beta1 feat: add order_by to pipeline_service in aiplatform v1beta1 feat: add model_display_name to prediction_service in aiplatform v1beta1 feat: add specialist_worker_emails to specialist_pool in aiplatform v1beta1 Committer: @dizcology PiperOrigin-RevId: 401280513 Source-Link: googleapis/googleapis@bf96877 feat: add context manager support in client chore: fix docstring for first attribute of protos committer: @busunkim96 PiperOrigin-RevId: 401271153 Source-Link: googleapis/googleapis@787f8c9 chore(spanner/admin/database): ensure samples are not autogenerated for libraries with a veneer PiperOrigin-RevId: 401094430 Source-Link: googleapis/googleapis@409e134 fix!: add a dummy change 2 at the v1 for testing release messages with commit body commit body 1 commit body 2 --- fix: add a dummy change 1 at the v1 for testing release messages without commit body --- chore!: add a dummy change 3 at the v1main for testing release messages without commit body --- build(lang)!: add a dummy change 2 at the v1main for testing release messages with commit body commit body1 commit body2 --- fix(lang)!: add a dummy change 1 at the v1main for testing release messages with commit body PiperOrigin-RevId: 401078164 Source-Link: googleapis/googleapis@0686b31 Synchronize new proto/yaml changes. PiperOrigin-RevId: 401076834 Source-Link: googleapis/googleapis@ec7b6ee build(networksecurity): update package name PiperOrigin-RevId: 401044668 Source-Link: googleapis/googleapis@d3ef31e chore(datafusion): update package name for npm data-fusion PiperOrigin-RevId: 401044637 Source-Link: googleapis/googleapis@90eb04f docs(video/transcoder): clarify that project number is used as the canonical project identifier for job and job template names docs: fix broken link and code formatting feat: add support for allow_missing param on DELETE request fix!: remove Encryption settings that were published due to a sync issue BREAKING CHANGE: requests specifying Encryption settings are rejected by the server PiperOrigin-RevId: 401033248 Source-Link: googleapis/googleapis@ef9130f build(security/privateca): update package name for security-private-ca PiperOrigin-RevId: 401006101 Source-Link: googleapis/googleapis@ac08aa4 docs: Fixed several broken links and formatting issues in the reference documentation PiperOrigin-RevId: 400904467 Source-Link: googleapis/googleapis@701a095 fix!: add a dummy change 2 at the v1 for testing release messages with commit body commit body 1 commit body 2 --- fix: add a dummy change 1 at the v1 for testing release messages without commit body --- chore!: add a dummy change 3 at the v1main for testing release messages without commit body --- build(lang)!: add a dummy change 2 at the v1main for testing release messages with commit body commit body1 commit body2 --- fix(lang)!: add a dummy change 1 at the v1main for testing release messages with commit body PiperOrigin-RevId: 400834178 Source-Link: googleapis/googleapis@1b18746 build: library of v1 showcase onboarded to SAM PiperOrigin-RevId: 400823250 Source-Link: googleapis/googleapis@70e4269 chore: regenerate API index Source-Link: googleapis/googleapis@7d82057 feat(dialogflow/cx): added deployment API feat: exposed DTMF input info in the query result docs: added notes on long running operation PiperOrigin-RevId: 400785744 Source-Link: googleapis/googleapis@bf8851e feat(dialogflow/cx): expose dtmf input info in the query result PiperOrigin-RevId: 400308975 Source-Link: googleapis/googleapis@02710fa chore: regenerate API index Source-Link: googleapis/googleapis@7706626 feat: Update Routes Preferred protos PiperOrigin-RevId: 400268071 Source-Link: googleapis/googleapis@0ee215a chore: Add build rules in BUILD.bazel for google/cloud/common protos for python PiperOrigin-RevId: 400225997 Source-Link: googleapis/googleapis@928286b
rajatbhatta
pushed a commit
to rajatbhatta/java-spanner
that referenced
this pull request
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporarily disables tests that are not working with the emulator.