test: fix ITTransactionManagerAsyncTest #706
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: spanner
olavloite
commented
Dec 10, 2020
| } | ||
|
|
||
| @Ignore( | ||
| "Cloud Spanner now seems to return CANCELLED instead of ABORTED when a transaction is invalidated by a later transaction in the same session") |
There was a problem hiding this comment.
This seems to be a slight behavioral change in Cloud Spanner: Starting a new read/write transaction on a session that already has a read/write transaction will invalidate the first transaction. As far as I can tell, that would previously return an ABORTED error. That seems to have been changed to a CANCELLED error, which does make sense as it is an indication of an application error rather than a transient server error.
thiagotnunes
approved these changes
Dec 10, 2020
thiagotnunes
pushed a commit
that referenced
this pull request
Jan 22, 2021
* test: fix test that would not run on both emulator and real Spanner * fix: add category to test to ensure it's executed
thiagotnunes
pushed a commit
that referenced
this pull request
May 6, 2021
* test: fix test that would not run on both emulator and real Spanner * fix: add category to test to ensure it's executed
ansh0l
pushed a commit
to ansh0l/java-spanner
that referenced
this pull request
Nov 10, 2022
This is an auto-generated regeneration of the .pb.go files by cloud.google.com/go/internal/gapicgen. Once this PR is submitted, genbot will update the corresponding PR to depend on the newer version of go-genproto, and assign reviewers. Whilst this or any regen PR is open in go-genproto, genbot will not create any more regeneration PRs. If all regen PRs are closed, gapicgen will create a new set of regeneration PRs once per night. If you have been assigned to review this PR, please: - Ensure that CI is passing. If it's failing, it requires your manual attention. - Approve and submit this PR if you believe it's ready to ship. That will prompt genbot to assign reviewers to the google-cloud-go PR. Corresponding google-cloud-go PR: googleapis/google-cloud-go#5010 Changes: chore: regenerate API index Source-Link: googleapis/googleapis@d5b19f1 feat(dialogflow/cx): added API for changelogs docs: clarified semantic of the streaming APIs PiperOrigin-RevId: 404659561 Source-Link: googleapis/googleapis@19943c1 chore: regenerate API index Source-Link: googleapis/googleapis@180ec36 feat(dialogflow/cx): added API for changelogs docs: clarified semantic of the streaming APIs PiperOrigin-RevId: 404644767 Source-Link: googleapis/googleapis@55fd11b feat: Publish Traffic Director log entry proto Committer: @karthikbox PiperOrigin-RevId: 404630120 Source-Link: googleapis/googleapis@30eeb27 fix(aiplatform): Remove invalid resource annotations Note: normally removing an annotation is a breaking change. However, the annotation here is invalid as it doesn't refer to a string field. Any generator which actually tried to use it in a meaningful way would either generate invalid code or fail to generate at all. Therefore removing it can't break anything. PiperOrigin-RevId: 404455880 Source-Link: googleapis/googleapis@dc83df8 build(nodejs): correct artifact name for npm PiperOrigin-RevId: 404411760 Source-Link: googleapis/googleapis@3fe45e2
rajatbhatta
pushed a commit
to rajatbhatta/java-spanner
that referenced
this pull request
Nov 17, 2022
🤖 I have created a release \*beep\* \*boop\* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ITTransactionManagerAsyncTest had a couple of problems:
Replaces #693