Skip to content

Commit 098c1d2

Browse files
partheaparthea
authored
fix: resolve broken link in PR body (#2579)
Fixes #2578
1 parent 6b10456 commit 098c1d2

File tree

4 files changed

+33
-33
lines changed

4 files changed

+33
-33
lines changed

‎internal/librarian/commit_version_analyzer_test.go‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -238,7 +238,7 @@ This is another body.
238238
239239
PiperOrigin-RevId: 573342
240240
Library-IDs: foo
241-
Source-link: [googleapis/googleapis@fedcba0](https://github.com/googleapis/googleapis/commit/fedcba0)
241+
Source-link: [googleapis/googleapis@fedcba09](https://github.com/googleapis/googleapis/commit/fedcba09)
242242
END_NESTED_COMMIT
243243
244244
BEGIN_NESTED_COMMIT
@@ -248,7 +248,7 @@ This is another body.
248248
249249
PiperOrigin-RevId: 573342
250250
Library-IDs: bar
251-
Source-link: [googleapis/googleapis@fedcba0](https://github.com/googleapis/googleapis/commit/fedcba0)
251+
Source-link: [googleapis/googleapis@fedcba09](https://github.com/googleapis/googleapis/commit/fedcba09)
252252
END_NESTED_COMMIT
253253
254254
BEGIN_NESTED_COMMIT
@@ -258,7 +258,7 @@ This is another body.
258258
259259
PiperOrigin-RevId: 573342
260260
Library-IDs: foo, bar
261-
Source-link: [googleapis/googleapis@fedcba0](https://github.com/googleapis/googleapis/commit/fedcba0)
261+
Source-link: [googleapis/googleapis@fedcba09](https://github.com/googleapis/googleapis/commit/fedcba09)
262262
END_NESTED_COMMIT
263263
264264
END_COMMIT_OVERRIDE`,
@@ -293,7 +293,7 @@ END_COMMIT_OVERRIDE`,
293293
Footers: map[string]string{
294294
"PiperOrigin-RevId": "573342",
295295
"Library-IDs": "foo",
296-
"Source-link": "[googleapis/googleapis@fedcba0](https://github.com/googleapis/googleapis/commit/fedcba0)",
296+
"Source-link": "[googleapis/googleapis@fedcba09](https://github.com/googleapis/googleapis/commit/fedcba09)",
297297
},
298298
IsNested: true,
299299
},
@@ -304,7 +304,7 @@ END_COMMIT_OVERRIDE`,
304304
Footers: map[string]string{
305305
"PiperOrigin-RevId": "573342",
306306
"Library-IDs": "foo, bar",
307-
"Source-link": "[googleapis/googleapis@fedcba0](https://github.com/googleapis/googleapis/commit/fedcba0)",
307+
"Source-link": "[googleapis/googleapis@fedcba09](https://github.com/googleapis/googleapis/commit/fedcba09)",
308308
},
309309
IsNested: true,
310310
},

‎internal/librarian/release_notes.go‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,10 +60,10 @@ var (
6060
}
6161

6262
shortSHA = func(sha string) string {
63-
if len(sha) < 7 {
63+
if len(sha) < 8 {
6464
return sha
6565
}
66-
return sha[:7]
66+
return sha[:8]
6767
}
6868

6969
releaseNotesTemplate = template.Must(template.New("releaseNotes").Funcs(template.FuncMap{

‎internal/librarian/release_notes_test.go‎

Lines changed: 24 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -125,15 +125,15 @@ This is another body.
125125
126126
PiperOrigin-RevId: 573342
127127
Library-IDs: one-library
128-
Source-link: [googleapis/googleapis@fedcba0](https://github.com/googleapis/googleapis/commit/fedcba0)
128+
Source-link: [googleapis/googleapis@fedcba09](https://github.com/googleapis/googleapis/commit/fedcba09)
129129
END_NESTED_COMMIT
130130
131131
END_COMMIT_OVERRIDE
132132
133133
This pull request is generated with proto changes between
134-
[googleapis/googleapis@abcdef0](https://github.com/googleapis/googleapis/commit/abcdef0000000000000000000000000000000000)
134+
[googleapis/googleapis@abcdef00](https://github.com/googleapis/googleapis/commit/abcdef0000000000000000000000000000000000)
135135
(exclusive) and
136-
[googleapis/googleapis@fedcba0](https://github.com/googleapis/googleapis/commit/fedcba0987654321000000000000000000000000)
136+
[googleapis/googleapis@fedcba09](https://github.com/googleapis/googleapis/commit/fedcba0987654321000000000000000000000000)
137137
(inclusive).
138138
139139
Librarian Version: %s
@@ -217,15 +217,15 @@ This is another body.
217217
218218
PiperOrigin-RevId: 573342
219219
Library-IDs: one-library,another-library
220-
Source-link: [googleapis/googleapis@fedcba0](https://github.com/googleapis/googleapis/commit/fedcba0)
220+
Source-link: [googleapis/googleapis@fedcba09](https://github.com/googleapis/googleapis/commit/fedcba09)
221221
END_NESTED_COMMIT
222222
223223
END_COMMIT_OVERRIDE
224224
225225
This pull request is generated with proto changes between
226-
[googleapis/googleapis@abcdef0](https://github.com/googleapis/googleapis/commit/abcdef0000000000000000000000000000000000)
226+
[googleapis/googleapis@abcdef00](https://github.com/googleapis/googleapis/commit/abcdef0000000000000000000000000000000000)
227227
(exclusive) and
228-
[googleapis/googleapis@fedcba0](https://github.com/googleapis/googleapis/commit/fedcba0987654321000000000000000000000000)
228+
[googleapis/googleapis@fedcba09](https://github.com/googleapis/googleapis/commit/fedcba0987654321000000000000000000000000)
229229
(inclusive).
230230
231231
Librarian Version: %s
@@ -306,15 +306,15 @@ This is another body.
306306
307307
PiperOrigin-RevId: 573342
308308
Library-IDs: one-library
309-
Source-link: [googleapis/googleapis@fedcba0](https://github.com/googleapis/googleapis/commit/fedcba0)
309+
Source-link: [googleapis/googleapis@fedcba09](https://github.com/googleapis/googleapis/commit/fedcba09)
310310
END_NESTED_COMMIT
311311
312312
END_COMMIT_OVERRIDE
313313
314314
This pull request is generated with proto changes between
315-
[googleapis/googleapis@abcdef0](https://github.com/googleapis/googleapis/commit/abcdef0000000000000000000000000000000000)
315+
[googleapis/googleapis@abcdef00](https://github.com/googleapis/googleapis/commit/abcdef0000000000000000000000000000000000)
316316
(exclusive) and
317-
[googleapis/googleapis@fedcba0](https://github.com/googleapis/googleapis/commit/fedcba0987654321000000000000000000000000)
317+
[googleapis/googleapis@fedcba09](https://github.com/googleapis/googleapis/commit/fedcba0987654321000000000000000000000000)
318318
(inclusive).
319319
320320
Librarian Version: %s
@@ -390,7 +390,7 @@ This is another body.
390390
391391
PiperOrigin-RevId: 573342
392392
Library-IDs: one-library
393-
Source-link: [googleapis/googleapis@fedcba0](https://github.com/googleapis/googleapis/commit/fedcba0)
393+
Source-link: [googleapis/googleapis@fedcba09](https://github.com/googleapis/googleapis/commit/fedcba09)
394394
END_NESTED_COMMIT
395395
396396
BEGIN_NESTED_COMMIT
@@ -399,15 +399,15 @@ This is body.
399399
400400
PiperOrigin-RevId: 98765
401401
Library-IDs: one-library
402-
Source-link: [googleapis/googleapis@1234567](https://github.com/googleapis/googleapis/commit/1234567)
402+
Source-link: [googleapis/googleapis@12345678](https://github.com/googleapis/googleapis/commit/12345678)
403403
END_NESTED_COMMIT
404404
405405
END_COMMIT_OVERRIDE
406406
407407
This pull request is generated with proto changes between
408-
[googleapis/googleapis@1234567](https://github.com/googleapis/googleapis/commit/1234567890000000000000000000000000000000)
408+
[googleapis/googleapis@12345678](https://github.com/googleapis/googleapis/commit/1234567890000000000000000000000000000000)
409409
(exclusive) and
410-
[googleapis/googleapis@fedcba0](https://github.com/googleapis/googleapis/commit/fedcba0987654321000000000000000000000000)
410+
[googleapis/googleapis@fedcba09](https://github.com/googleapis/googleapis/commit/fedcba0987654321000000000000000000000000)
411411
(inclusive).
412412
413413
Librarian Version: %s
@@ -948,11 +948,11 @@ Language Image: go:1.21
948948
949949
### Features
950950
951-
* new feature ([1234567](https://github.com/owner/repo/commit/1234567))
951+
* new feature ([12345678](https://github.com/owner/repo/commit/12345678))
952952
953953
### Bug Fixes
954954
955-
* a bug fix ([fedcba0](https://github.com/owner/repo/commit/fedcba0))
955+
* a bug fix ([fedcba09](https://github.com/owner/repo/commit/fedcba09))
956956
957957
</details>`,
958958
librarianVersion, today),
@@ -994,11 +994,11 @@ Language Image: go:1.21
994994
995995
### Features
996996
997-
* new feature (PiperOrigin-RevId: 123456) ([1234567](https://github.com/owner/repo/commit/1234567))
997+
* new feature (PiperOrigin-RevId: 123456) ([12345678](https://github.com/owner/repo/commit/12345678))
998998
999999
### Bug Fixes
10001000
1001-
* a bug fix (PiperOrigin-RevId: 987654) ([fedcba0](https://github.com/owner/repo/commit/fedcba0))
1001+
* a bug fix (PiperOrigin-RevId: 987654) ([fedcba09](https://github.com/owner/repo/commit/fedcba09))
10021002
10031003
</details>`,
10041004
librarianVersion, today),
@@ -1038,9 +1038,9 @@ Language Image: go:1.21
10381038
10391039
### Features
10401040
1041-
* new feature ([1234567](https://github.com/owner/repo/commit/1234567))
1041+
* new feature ([12345678](https://github.com/owner/repo/commit/12345678))
10421042
1043-
* another new feature ([fedcba0](https://github.com/owner/repo/commit/fedcba0))
1043+
* another new feature ([fedcba09](https://github.com/owner/repo/commit/fedcba09))
10441044
10451045
</details>`,
10461046
librarianVersion, today),
@@ -1089,7 +1089,7 @@ Language Image: go:1.21
10891089
10901090
### Features
10911091
1092-
* feature for a ([1234567](https://github.com/owner/repo/commit/1234567))
1092+
* feature for a ([12345678](https://github.com/owner/repo/commit/12345678))
10931093
10941094
</details>
10951095
@@ -1100,7 +1100,7 @@ Language Image: go:1.21
11001100
11011101
### Bug Fixes
11021102
1103-
* fix for b ([fedcba0](https://github.com/owner/repo/commit/fedcba0))
1103+
* fix for b ([fedcba09](https://github.com/owner/repo/commit/fedcba09))
11041104
11051105
</details>`,
11061106
librarianVersion, today, today),
@@ -1140,7 +1140,7 @@ Language Image: go:1.21
11401140
11411141
### Features
11421142
1143-
* new feature ([1234567](https://github.com/owner/repo/commit/1234567))
1143+
* new feature ([12345678](https://github.com/owner/repo/commit/12345678))
11441144
11451145
</details>`,
11461146
librarianVersion, today),
@@ -1176,7 +1176,7 @@ Language Image: go:1.21
11761176
11771177
### Features
11781178
1179-
* new feature ([1234567](https://github.com/owner/repo/commit/1234567))
1179+
* new feature ([12345678](https://github.com/owner/repo/commit/12345678))
11801180
11811181
</details>`,
11821182
librarianVersion, today),
@@ -1221,7 +1221,7 @@ Language Image: go:1.21
12211221
12221222
### Miscellaneous Chores
12231223
1224-
* some chore ([1234567](https://github.com/owner/repo/commit/1234567))
1224+
* some chore ([12345678](https://github.com/owner/repo/commit/12345678))
12251225
12261226
</details>`,
12271227
librarianVersion, today),

‎internal/librarian/tag_and_release_test.go‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -259,7 +259,7 @@ Language Image: gcr.io/test/image:latest
259259
260260
### Features
261261
262-
* some feature ([1234567](https://github.com/googleapis/repo/commit/1234567))
262+
* some feature ([12345678](https://github.com/googleapis/repo/commit/12345678))
263263
264264
</details>
265265
@@ -280,7 +280,7 @@ Language Image: gcr.io/test/image:latest
280280
281281
### Features
282282
283-
* some feature ([1234567](https://github.com/googleapis/repo/commit/1234567))`,
283+
* some feature ([12345678](https://github.com/googleapis/repo/commit/12345678))`,
284284
},
285285
{
286286
Version: "2.3.4",

0 commit comments

Comments
 (0)