-
Notifications
You must be signed in to change notification settings - Fork 321
feat: adds support for Python runtime 3.14 #2322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the GitHub presubmits, I see the unit tests for 3.14 ran, but the sample tests for 3.14 did not . Neither did Kokoro snippets and Kokoro system, for 3.14. It looks from our guide that at least the samples test should be configured to run. And it would be great to get the Kokoro test to run right away as well, though tbh i don't know whether those depend on additional configs.
.github/workflows/unittest.yml
Outdated
| python -m pip install nox | ||
| - name: Run unit tests | ||
|
|
||
| # TODO 3.14 is not yet supported by pyarrow. See |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you file an issue to track this, and mention it in the TODO. Something like:
TODO(http://....): Re-enable tests on Python 3.14 once....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Github issues automatically become buganizer issues for this repo. There is no need for me to file an issue.
I will add the buganizer number, per request.
noxfile.py
Outdated
| DEFAULT_PYTHON_VERSION = "3.9" | ||
| SYSTEM_TEST_PYTHON_VERSIONS = ["3.9", "3.11", "3.12", "3.13"] | ||
| UNIT_TEST_PYTHON_VERSIONS = ["3.9", "3.11", "3.12", "3.13"] | ||
| UNIT_TEST_PYTHON_VERSIONS = ["3.9", "3.11", "3.12", "3.13", "3.14"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is 3.10 missing (even before this PR)? Either we test on all supported versions, or we sample fewer (like the lowest and highest), don't you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated.
|
DONE:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this! Just one non-blocking cosmetic comment.
| # TODO (https://b.corp.google.com/issues/450370502) 3.14 is not yet supported by pyarrow. See | ||
| # https://github.com/googleapis/google-cloud-python/issues/14686 | ||
| # https://github.com/apache/arrow/issues/47438 | ||
| # Reinstate running tests with 3.14 once this bug is fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's avoid references to internal issues where we can.
| # TODO (https://b.corp.google.com/issues/450370502) 3.14 is not yet supported by pyarrow. See | |
| # https://github.com/googleapis/google-cloud-python/issues/14686 | |
| # https://github.com/apache/arrow/issues/47438 | |
| # Reinstate running tests with 3.14 once this bug is fixed | |
| # TODO (https://github.com/googleapis/google-cloud-python/issues/14686) Reinstate running | |
| # tests with 3.14 once Python 3.14 is supported by pyarrow. | |
| # See also https://github.com/apache/arrow/issues/47438 |
This PR updates the python-bigquery library to add support for Python 3.14.
The following changes have been made:
(bqstorage, pandas) in pyproject.toml.
These changes ensure that the library is tested against Python 3.14 and declares support for it, while also handling the new
grpciodependency requirement.