Skip to content
This repository was archived by the owner on Nov 29, 2023. It is now read-only.

Conversation

@busunkim96
Copy link
Contributor

Allow google-api-core<3.0.0dev on previous release of library. Note that this PR is to a new protected branch v1, not main.

This will be followed by a release PR and is a step towards removing googleapis/google-cloud-python#10566

@busunkim96 busunkim96 requested a review from parthea March 10, 2022 23:41
@product-auto-label product-auto-label bot added the api: container Issues related to the googleapis/python-container API. label Mar 10, 2022
@parthea parthea changed the title chore(deps): allow google-api-core v2 on v1 release fix(deps): require google-api-core >= 1.31.5, >= 2.3.2 on v1 release Mar 14, 2022
@Shabirmean
Copy link
Contributor

Hey @parthea, Can we merge this? Or are you holding off on something else.

@parthea parthea merged commit ee7d172 into v1 Mar 15, 2022
@parthea parthea deleted the v1-api-core-pin branch March 15, 2022 14:47
@busunkim96 busunkim96 added the release-please:force-run To run release-please label Mar 31, 2022
@release-please release-please bot removed the release-please:force-run To run release-please label Mar 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: container Issues related to the googleapis/python-container API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants