This repository was archived by the owner on Oct 29, 2023. It is now read-only.
Bump utils-java dependency. #206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And update code to reflect the new signature for the variant merge strategy.
| <properties> | ||
| <!-- Work around dataflow, grpc, and protobuf version issues | ||
| http://stackoverflow.com/questions/36257708/java-lang-noclassdeffounderror-while-deserializing-protobuf-messages --> | ||
| <google.dataflow.version>1.6.0</google.dataflow.version> |
There was a problem hiding this comment.
Shouldn't this be 4.1.1.Final instead based on the following:
<dependency>
<groupId>io.netty</groupId>
<artifactId>netty-codec-http2</artifactId>
<version>[4.1.1.Final]</version>
<scope>compile</scope>
</dependency>The above is from the following pom in Maven:
https://repo1.maven.org/maven2/io/grpc/grpc-netty/0.15.0/grpc-netty-0.15.0.pom
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also
Some of these changes were already reviewed in a prior PR sent to a branch pending the new release of utils-java.