run golint and add it to tests

[zemirco]

I've used golint to make some minor improvements to the code. I also added it to the automatic checks at Circle CI.

[zemirco]

I'm not sure but it looks like unit tests at Circle CI do not run whenever I create a PR. Any idea how to change that?

[zemirco]

Here is the link https://circleci.com/docs/2.0/oss/#build-pull-requests-from-forked-repositories

[wmnsk]

Thanks @zemirco
No doubt, golinting is important, and i’m happy you care about this.
I was just thinking about file issues to improve code quality, with this report.
https://goreportcard.com/report/github.com/wmnsk/gopcua

I updated the CCI config. Maybe next time it works.

[zemirco]

Cool thank you! I made another commit and now it seems to work.

[wmnsk]

OK I confirmed golint prints nothing in CCI output.
Would you still have anything in your mind to add to this branch? Otherwise let me merge your changes.

[zemirco]

No nothing to add.

If you want I could add more checkers like

• go vet ./...
• https://github.com/mvdan/interfacer
• https://github.com/kisielk/errcheck
• https://github.com/gordonklaus/ineffassign
• https://github.com/opennota/check
• https://github.com/dominikh/go-tools
• https://github.com/mvdan/unparam

Maybe adding go vet ./... is a good idea. It's already included and we don't have to install anything.

[wmnsk]

Then I’ll merge this PR.

As for checkers let me consider which to follow. In fact my editor has been telling me some issues but I have not cared so much so far, as I thought no one is interested in this project at this moment...
Anyway I’ll create an issue to track and discuss it.