Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility / screen reader issue, after clicking the toolbar button, the shown up interface is not accessible with screen reader keyboard control #2072

Closed
sine-w opened this issue Oct 16, 2016 · 10 comments

Comments

@sine-w
Copy link

sine-w commented Oct 16, 2016

Read first: https://github.com/gorhill/uBlock/blob/master/CONTRIBUTING.md

Describe the issue

As title suggested, I am a screen reader user.
I try clicking the toolbar button however, the shown up interface seemed like is an overlay interface and is not accessible with screen reader using keyboard control.

@gorhill
Copy link
Owner

gorhill commented Oct 16, 2016

uBlock Origin's tabbed dashboard uses an iframe, which iframe is filled with the settings corresponding to the currently selected tab. Could the use of an iframe be the issue?

For example, do you have an issue reading this page: http://codepen.io/Mahmoud-Zakaria/pen/zKLrkY?

@sine-w
Copy link
Author

sine-w commented Oct 16, 2016

Thanks for your reply.
Yes, screen reader can access iframe, like that of youtube. But after I
clicked the ublock button, I knew that something appear up, but, the
keyboard is trapped and it cannot move around use arrow keys.
Besides, I can do it by pressing tap keys but since many items are
unknown, for example it only say 'link' and making impossible to do the
setting.

Raymond Hill 於 16/10/2016 20:09 寫道:

uBlock Origin's tabbed dashboard uses an |iframe|, which |iframe| is
filled with the settings corresponding to the currently selected tab.
Could the use of an |iframe| be the issue?

For example, do you have an issue reading this page:
http://codepen.io/Mahmoud-Zakaria/pen/zKLrkY?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#2072 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/APVJnUkw59KxGCu4POfzaEApwMzd2zUrks5q0hPxgaJpZM4KX80C.

@gorhill
Copy link
Owner

gorhill commented Oct 16, 2016

since many items are unknown, for example it only say 'link' and making impossible to do the setting

To help me find out which items are unknown, can you list the items which are known?

@sine-w
Copy link
Author

sine-w commented Oct 17, 2016

Hi, thanks.
Well, in fact I don't know what happen with that interface.......there
are some hyperlinks, which my screen reader only say 'link'.
And there is a heading, without text.
There are many iteams, e.g. 3p frame, image, said it is text element,
and not knowing what it is for.

Raymond Hill 於 16/10/2016 21:06 寫道:

since many items are unknown, for example it only say 'link' and
making impossible to do the setting

To help me find out which items are unknown, can you list the items
which are known?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#2072 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/APVJncOC_GL_69GRe6TncR1KIksvwG2iks5q0iE_gaJpZM4KX80C.

@gorhill
Copy link
Owner

gorhill commented Oct 17, 2016

OK I understand, you are referring to the UI of the popup panel, not the dashboard.

@pitermach
Copy link

I'm bumping this issue as it's still a serious problem. It's not so much the fact that it can't be navigated with the keyboard, but most of the controls aren't visible. Testing with Chrome and the free NVDA screen reader on Windows as well as VoiceOver on Mac OS, after pressing the uBlock button on the toolbar I can only see 2 unlabeled links that go to the logger and the actual dashboard. But I can't see the buttons that can be used to quickly turn uBlock off on a page. I guess it's not a standard HTML control so NVDA can't pick it up and you can't tab to it either. Setting the appropriate aria roll to tell screen readers the type of control (I guess checkbox would be appropriate for the uBlock toggle) and aria labels to explain what they do would make the extension a lot easier to use. Because right now whenever I want to exclude a site I have to manually drill down to the settings and paste the url into the exclusion list which is a bit frustrating.

@gorhill
Copy link
Owner

gorhill commented Nov 9, 2017

I made changes which hopefully fix the issue, but it's not something I can test myself. If you are willing to test with the development build of uBlock, that would be great to have feedback as to whether things are better now.

The development build of uBlock can be installed from the Chrome store: https://chrome.google.com/webstore/detail/ublock-origin-dev-build/cgbcahbpdhpcegmbfconppldiemgcoii.

@pitermach
Copy link

pitermach commented Nov 9, 2017 via email

gorhill added a commit that referenced this issue Nov 10, 2017
@gorhill
Copy link
Owner

gorhill commented Nov 11, 2017

The new dev build was finally cleared on AMO in Chrome store, can you try it?

I was already using aria-label, but I followed the other advices at the link you provided (role= and tabindex=). I also added "Open the logger" and "Open the dashboard", I had assumed these were self-explanatory.

@pitermach
Copy link

pitermach commented Nov 11, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants