Fetch and present task outcomes #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This required a small tweak to the code that uses the generated client.
jthurne
force-pushed
the
jhurne/task-metrics
branch
from
e396edd to
534dcd3
Compare
…tible. This allows the build to work, but the configuration cache is used a lot less as a result. The better solution is to ask the codegen maintainers to fix the plugin to be configuraiton-cache compatible. diff --git a/components/fetch-build-scan-data-cmdline-tool/build.gradle.kts b/components/fetch-build-scan-data-cmdline-tool/build.gradle.kts index 068db94..f93bcb4 100644 --- a/components/fetch-build-scan-data-cmdline-tool/build.gradle.kts +++ b/components/fetch-build-scan-data-cmdline-tool/build.gradle.kts @@ -1,3 +1,5 @@ +import org.hidetake.gradle.swagger.generator.GenerateSwaggerCode + plugins { java application @@ -65,6 +67,10 @@ tasks.compileJava { options.encoding = "UTF-8" } +tasks.withType(GenerateSwaggerCode::class) { + notCompatibleWithConfigurationCache("Accesses the project at execution time.") +} + application { mainClass.set("com.gradle.enterprise.Main") }
Includes displaying avoidance savings and durations (execution times). Also reduces the number of fields returned when fetching a build scan.
* origin/main: Include component builds in dependabot configuration Update GE Maven extension plugin to 1.14.2 Update CCUD plugin to 1.7.1
…data This constrains what version of Gradle Enterprise the build validation scripts will support, but it really simplifies things.
Some of these were needed when we wrote our own Export API client.
We'll re-add it in a separate PR.
Reduces the amount of code that is generated. This will also make it easier to wire the source set into the build.
...by adding the output from the code generation task directly to the java main source set.
It is possible to configure Gradle Enterprise to allow anonymous users to read build scan data.
…t exceptions This makes it easier to troubleshoot certain types of errors.
To configure an HTTP proxy, edit the proxy.settings file found in the root of the build validation scripts and uncomment and edit the appropriate lines. HTTP Proxy authentication is not yet supported. SOCKS proxy support may work (by setting socksProxyHost and socksProxyPort), but this is untested.
marcphilipp
reviewed
Jun 8, 2022
| @@ -166,6 +166,8 @@ fetch_and_read_build_scan_data() { | |||
| args+=(-m "${mapping_file}") | |||
| fi | |||
|
|
|||
| args+=("--proxy-settings-file" "${SCRIPT_DIR}/proxy.settings") | |||
There was a problem hiding this comment.
Minor: I think we should use .properties here so that editors/IDEs can help with editing.
|
Wonderful work, @jthurne . This is now going to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.