Add support for CLIENT_JAVA_HOME #434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jthurne
changed the title
jthurne
commented
May 11, 2023
erichaagdev
approved these changes
May 11, 2023
erichaagdev
reviewed
May 18, 2023
Users can use CLIENT_JAVA_HOME to override which JVM is used to execute the Build Scan clients. The other JVMs used (for running Gradle and for building code) are not affected.
Co-authored-by: Eric Haag <ehaag@gradle.com> Signed-off-by: Jim Hurne <jhurne@gradle.com>
erichaagdev
force-pushed
the
jhurne/allow-setting-client-java-home
branch
from
ce02ec1 to
b052dd0
Compare
|
I tested this and confirmed it works. Written below is what I did to test this:
$ java -version
openjdk version "1.8.0_362"
OpenJDK Runtime Environment (Zulu 8.68.0.19-CA-macos-aarch64) (build 1.8.0_362-b08)
OpenJDK 64-Bit Server VM (Zulu 8.68.0.19-CA-macos-aarch64) (build 25.362-b08, mixed mode)
$ ./03-validate-local-build-caching-different-locations.sh \
-r https://github.com/etiennestuder/java-ordered-properties \
-t build \
-c d54ff833f3337ec6df6ab7b5157d36e12af8b6ae \
-x \
--debug
$ CLIENT_JAVA_HOME="$JDK17" \
./03-validate-local-build-caching-different-locations.sh \
-r https://github.com/etiennestuder/java-ordered-properties \
-t build \
-c d54ff833f3337ec6df6ab7b5157d36e12af8b6ae \
-x \
--debug
Uploading the scan dump and we can see the build was still invoked with the system's currently configured Java runtime.
|
|
@erichaagdev Thanks for the testing and merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users can use
CLIENT_JAVA_HOMEto override which JVM is used to execute theBuild Scan clients. The other JVMs used (for running Gradle and for building
code) are not affected.
Fixes #428