Scripts wait longer for builds to ingest when --fail-if-not-fully-cacheable is used
#791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielfeo
approved these changes
Jan 27, 2025
ribafish
approved these changes
Jan 27, 2025
17 tasks
jthurne
approved these changes
Jan 29, 2025
erichaagdev
force-pushed
the
erichaagdev/fail-unknown-perf-char-f
branch
from
78c5450 to
333d22f
Compare
erichaagdev
force-pushed
the
erichaagdev/wait-timeout-f
branch
2 times, most recently
from
8ecf61d to
213f378
Compare
…` is used This change adds the `--availability-wait-timeout` option to the build scan summary tool invocation with a value of '60' when the `--fail-if-not-fully-cacheable` option is used. This should increase the likelihood of experiment build scans being ingested in order to retrieve the required data from the Develocity API to determine cacheability.
erichaagdev
force-pushed
the
erichaagdev/wait-timeout-f
branch
from
213f378 to
5f47a32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the
--availability-wait-timeoutoption to the build scan summary tool invocation with a value of '60' when the--fail-if-not-fully-cacheableoption is used.This should increase the likelihood of experiment build scans being ingested in order to retrieve the required data from the Develocity API to determine cacheability.
The
availabilityWaitTimeoutSecsquery parameter is included on the Develocity API calls when the--fail-if-not-fully-cacheableoption is included in the script invocation.When the
--fail-if-not-fully-cacheableoption isn't included, noavailabilityWaitTimeoutSecsparameter is included in the Develocity API call.Closes #505