Metrics: Add http_response_size_bytes metric #110428
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshhunt
requested review from
samsch and
ashharrison90
and removed request for
a team
ashharrison90
approved these changes
Sep 2, 2025
pkg/middleware/request_metrics.go
Outdated
| func RequestMetrics(features featuremgmt.FeatureToggles, cfg *setting.Cfg, promRegister prometheus.Registerer) web.Middleware { | ||
| log := log.New("middleware.request-metrics") | ||
|
|
||
| log.Info("initializing request metrics middleware", "size_buckets", sizeDefBuckets) |
There was a problem hiding this comment.
was this for debug, or do we actually want it? 🤔
joshhunt
force-pushed
the
jh/response-size-metric
branch
from
21c1fa8 to
4168e61
Compare
pkg/middleware/request_metrics.go
Outdated
| durationHistogram.Observe(elapsedTime) | ||
| } | ||
|
|
||
| sizeHistogram.Observe(float64(rw.Size())) |
There was a problem hiding this comment.
why not also observe with an exemplar for this one? seems like it might be useful...
There was a problem hiding this comment.
ngl the code kinda scared me a little bit so i just ignored it, figuring if it's the right thing to do someone will tell me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/public/route handler label value down into more granularplugin-assetsandpublic-build-assets.public-assetsis still there, but is a fallback that we want to get down to 0.Fixes https://github.com/grafana/grafana-frontend-platform/issues/33