Skip to content

Conversation

MattDodsonEnglish
Copy link
Contributor

- And some general language and formatting clean up.
- Fixes #826
@MattDodsonEnglish MattDodsonEnglish marked this pull request as ready for review January 10, 2023 20:01
@MattDodsonEnglish
Copy link
Contributor Author

@mstoykov I flagged you for review because you are the one who made issue #826 .

You don't need to review the other content edits, only just the two sections in headed API S[tress|pike] tests in k6.

I want to make sure that the intro and the scripts are appropriate and something that can be conveniently copied and run locally.

@github-actions
Copy link
Contributor

There's a version of the docs published here:

https://mdr-ci.staging.k6.io/docs/refs/pull/978/merge

It will be deleted automatically in 30 days.

![Virtual user chart of an API stress test](./images/stress-test.png)

This configuration increases the load by 100 users every 2 minutes and stays at this level for
![Virtual user chart of an API stress test](./images/stress-test.png "This configuration increases the load by 100 users every 2 minutes and stays at this level for
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment is accurate for hte picture but not the test above. I am not certain there needs to be a picture with VUs here - the important part is that the required target is hit. Not certain if there is a good graph for that 🤷

![Virtual user chart of a spike test](./images/spike-test.png)

Note, the test starts with a period of 1 minute of low load, a quick spike to very high load, followed by a recovery period of low load.
![Virtual user chart of a spike test](./images/spike-test.png "The test starts with a period of 1 minute of low load, a quick spike to very high load, followed by a recovery period of low load.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately k6 at this point (IIRC) reports all the allocated VUs as constnatly in use even if thre are doesn't require it. So if you have allocated 1000 VUs and need 1 to do 1 IPS it will still report 1000. Mostly because it in practice reports how many are active more then anything else. So this graph is ... misleading and I am not certain is needed.

Copy link
Contributor

@mstoykov mstoykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on the test and text changes, but I would just drop the graphs at this point in time.

@MattDodsonEnglish MattDodsonEnglish merged commit 354b347 into main Jan 16, 2023
@MattDodsonEnglish MattDodsonEnglish deleted the 826-spike branch January 16, 2023 11:39
imiric pushed a commit that referenced this pull request Feb 21, 2023
Some of the images on the "Stress testing" guide[1] were removed and
some text was mangled in #978.

[1]: https://k6.io/docs/test-types/stress-testing/
ppcano pushed a commit that referenced this pull request Feb 21, 2023
Some of the images on the "Stress testing" guide[1] were removed and
some text was mangled in #978.

[1]: https://k6.io/docs/test-types/stress-testing/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Spike test example uses closed model instead of open one

2 participants