(chore) Bloom Gateway: Avoid unnecessary merging of tasks prior to passing them to the FusedQuerier #11809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The requestIterator can be built directly from the task and does not require any unnecessary merging, since this is done by the FusedQuerier already. Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
chaudum
changed the title
taskMergeIterator with requestIterator
salvacorts
approved these changes
Jan 29, 2024
rhnasc
pushed a commit
to inloco/loki
that referenced
this pull request
Apr 12, 2024
…ssing them to the FusedQuerier (grafana#11809) **What this PR does / why we need it**: The `requestIterator` (`v1.Iterator[v1.Request]`) can be built directly from the task and does not require any unnecessary merging of tasks, since this is done by the `v1.FusedQuerier` already. Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The
requestIterator(v1.Iterator[v1.Request]) can be built directly from the task and does not require any unnecessary merging of tasks, since this is done by thev1.FusedQuerieralready.