Bloom Gateway: Extract processing logic from bloom worker into separate struct #11812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaudum
force-pushed
the
chaudum/extract-processor
branch
from
e739f6c to
cd28931
Compare
The processor executes a set of tasks.It cleanly separates I/O from logic and therefore is more testable than the current worker implementation. Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
chaudum
force-pushed
the
chaudum/extract-processor
branch
from
92a7874 to
9602214
Compare
owen-d
approved these changes
Jan 29, 2024
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
rhnasc
pushed a commit
to inloco/loki
that referenced
this pull request
Apr 12, 2024
…te struct (grafana#11812) **What this PR does / why we need it**: The processor executes a set of tasks. It cleanly separates I/O from logic and therefore is more testable than the current worker implementation. https://github.com/grafana/loki/blob/9602214abf5f0b016f1cad90e921d1e4d969856c/pkg/bloomgateway/processor.go#L33-L36 **Note**: The processor is not used yet in the worker. **Certain parts must be refactored when grafana#11810 is merged.** --------- Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The processor executes a set of tasks.
It cleanly separates I/O from logic and therefore is more testable than the current worker implementation.
loki/pkg/bloomgateway/processor.go
Lines 33 to 36 in 9602214
Note:
Only commit cd28931 is relevant. The rest of the commits are part of different PRs (#11792 and #11809), which need to be merged first.The processor is not used yet in the worker.
Certain parts must be refactored when #11810 is merged.