-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update out of order with main #2072
Update out of order with main #2072
Commits on Apr 26, 2022
-
Extend Makefile and Dockerfiles to support multiarch builds for all G…
…o binaries. (#1759) * Extend Dockerfiles to support multiarch builds for all Go binaries. By calling any of make push-multiarch-./cmd/metaconvert/.uptodate make push-multiarch-./cmd/mimir/.uptodate make push-multiarch-./cmd/query-tee/.uptodate make push-multiarch-./cmd/mimir-continuous-test/.uptodate make push-multiarch-./cmd/mimirtool/.uptodate make push-multiarch-./operations/mimir-rules-action/.uptodate Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 533cef6 - Browse repository at this point
Copy the full SHA 533cef6View commit details -
Update to latest dskit and memberlist fork (#1758)
* Update to latest dskit and memberlist fork Fixes #1743 Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com> * Update changelog Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
Configuration menu - View commit details
-
Copy full SHA for 209fc0f - Browse repository at this point
Copy the full SHA 209fc0fView commit details -
update cli parameter description (#1760)
Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for b406e9e - Browse repository at this point
Copy the full SHA b406e9eView commit details
Commits on Apr 27, 2022
-
mimirtool config: Add more retained old defaults (#1762)
* mimirtool config: Add more retained old defaults The following parameters have their old defaults retained even when `--update-defaults` is used with `mimirtool config covert`: * `activity_tracker.filepath` * `alertmanager.data_dir` * `blocks_storage.filesystem.dir` * `compactor.data_dir` * `ruler.rule_path` * `ruler_storage.filesystem.dir` * `graphite.querier.schemas.backend` (only in GEM) These are filepaths for which the new defaults don't make more sense than the old ones. In fact updating these can lead to subpar migration experience because components start using directories that don't exist. Because activity_tracker.filepath changed its name since cortex the tests needed to allow for differentiating old common options and new ones. This is something that was already there for GEM and was added for cortex/mimir too. Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * Update CHANGELOG.md Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Configuration menu - View commit details
-
Copy full SHA for 45baf66 - Browse repository at this point
Copy the full SHA 45baf66View commit details -
dashboards: add flag to skip gateway (#1761)
* dashboards: add flag to skip gateway The gateway component seems to be an enterprise component, so groups that aren't running enterprise shouldn't need the empty panels and rows in their dashboards. This patch adds a flag to drop gateway-related widgets from the mixin dashboards. Signed-off-by: Josh Carp <jm.carp@gmail.com> * Update CHANGELOG.md Co-authored-by: Marco Pracucci <marco@pracucci.com>
Configuration menu - View commit details
-
Copy full SHA for 198f017 - Browse repository at this point
Copy the full SHA 198f017View commit details -
Gracefully shutdown querier when using query-scheduler (#1756)
* Gracefully shutdown querier when using query-scheduler Signed-off-by: Marco Pracucci <marco@pracucci.com> * Fixed comment Signed-off-by: Marco Pracucci <marco@pracucci.com> * Added TestQueuesOnTerminatingQuerier Signed-off-by: Marco Pracucci <marco@pracucci.com> * Commented executionContext Signed-off-by: Marco Pracucci <marco@pracucci.com> * Added CHANGELOG entry Signed-off-by: Marco Pracucci <marco@pracucci.com> * Update pkg/querier/worker/util.go Co-authored-by: Peter Štibraný <pstibrany@gmail.com> * Fixed typo in suggestion Signed-off-by: Marco Pracucci <marco@pracucci.com> * Removed superfluous time sensitive assertion Signed-off-by: Marco Pracucci <marco@pracucci.com> * Commented newExecutionContext() Signed-off-by: Marco Pracucci <marco@pracucci.com> Co-authored-by: Peter Štibraný <pstibrany@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 56de1d0 - Browse repository at this point
Copy the full SHA 56de1d0View commit details
Commits on Apr 28, 2022
-
Graceful shutdown querier without query-scheduler (#1767)
* Graceful shutdown querier with not using query-scheduler Signed-off-by: Marco Pracucci <marco@pracucci.com> * Updated CHANGELOG entry Signed-off-by: Marco Pracucci <marco@pracucci.com> * Improved comment Signed-off-by: Marco Pracucci <marco@pracucci.com> * Refactoring Signed-off-by: Marco Pracucci <marco@pracucci.com>
Configuration menu - View commit details
-
Copy full SHA for c44b0bd - Browse repository at this point
Copy the full SHA c44b0bdView commit details -
Increase continuous test query timeout (#1777)
* Increase mimir-continuous-test query timeout from 30s to 60 Signed-off-by: Marco Pracucci <marco@pracucci.com> * Added PR number to CHANGELOG entry Signed-off-by: Marco Pracucci <marco@pracucci.com>
Configuration menu - View commit details
-
Copy full SHA for abedab7 - Browse repository at this point
Copy the full SHA abedab7View commit details -
Increased default -tests.run-interval from 1m to 5m (#1778)
* Increased default -tests.run-interval from 1m to 5m Signed-off-by: Marco Pracucci <marco@pracucci.com> * Added PR number to CHANGELOG entry Signed-off-by: Marco Pracucci <marco@pracucci.com>
Configuration menu - View commit details
-
Copy full SHA for 1e17cd8 - Browse repository at this point
Copy the full SHA 1e17cd8View commit details -
Fix flaky tests on querier graceful shutdown (#1779)
* Fix flaky tests on querier graceful shutdown Signed-off-by: Marco Pracucci <marco@pracucci.com> * Remove spurious newline Signed-off-by: Marco Pracucci <marco@pracucci.com>
Configuration menu - View commit details
-
Copy full SHA for 3a401ca - Browse repository at this point
Copy the full SHA 3a401caView commit details -
Update build image and GitHub workflow (#1781)
* Update build-image to use golang:1.17.8-bullseye, and add skopeo to build image. Skopeo will be used in subsequent PR to push multiarch images. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> * Update build image. Use ubuntu-latest for workflow steps. Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 777cdeb - Browse repository at this point
Copy the full SHA 777cdebView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7e8af99 - Browse repository at this point
Copy the full SHA 7e8af99View commit details -
Publish multiarch images (#1772)
* Publish multiarch images. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> * Tag with extra tag, if pushing tagged commit or release. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> * Split building of docker images and archiving them into tar. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> * When tagging with test, use --all. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> * Only run deploy step on tags or weekly release branches. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> * Don't tag with test anymore. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> * Address review feedback. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> * Fix license check. Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 413b46e - Browse repository at this point
Copy the full SHA 413b46eView commit details -
K6: Take into account HTTP status code 202 (#1787)
When using `K6_HA_REPLICAS > 1`, Mimir will accept all HTTP calls but a part of those call will receive a status code `202`. The following commit makes this status code as expected otherwise user receive the following error: ``` reads_inat write (file:///.../mimir-k6/load-testing-with-k6.js:254:8(137)) reads_inat native executor=ramping-arrival-rate scenario=writing_metrics source=stacktrace ERRO[0015] GoError: ERR: write failed. Status: 202. Body: replicas did not mach, rejecting sample: replica=replica_1, elected=replica_0 ``` At the end of the benchmark summary display errors: ``` ✗ write worked ↳ 20% — ✓ 23 / ✗ 92 ``` Example of load testing: ```shell ./k6 run load-testing-with-k6.js \ -e K6_SCHEME="https" \ -e K6_WRITE_HOSTNAME="${mimir}" \ -e K6_READ_HOSTNAME="${mimir}" \ -e K6_USERNAME="${user}" \ -e K6_WRITE_TOKEN="${password}" \ -e K6_READ_TOKEN="${password}" \ -e K6_HA_CLUSTERS="1" \ -e K6_HA_REPLICAS="3" \ -e K6_DURATION_MIN="5" ``` Signed-off-by: Wilfried Roset <wilfriedroset@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 971a26c - Browse repository at this point
Copy the full SHA 971a26cView commit details
Commits on Apr 29, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 62148b2 - Browse repository at this point
Copy the full SHA 62148b2View commit details -
* implement read v2 * updated CHANGELOG.md * extend maxBytesInFram comment. * addressed PR feedback * addressed PR feedback * addressed PR feedback * use indexed xor chunk function to assert stream remote read tests * updated CHANGELOG.md Co-authored-by: Miguel Ángel Ortuño <miguel.ortuno@grafana.com>
Configuration menu - View commit details
-
Copy full SHA for f33dde0 - Browse repository at this point
Copy the full SHA f33dde0View commit details -
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Configuration menu - View commit details
-
Copy full SHA for dd90026 - Browse repository at this point
Copy the full SHA dd90026View commit details -
Fix mimir-continuous-test when changing configured num-series (#1775)
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Configuration menu - View commit details
-
Copy full SHA for c18b5ab - Browse repository at this point
Copy the full SHA c18b5abView commit details -
Do not export per user and integration Alertmanager metrics when valu…
…e is 0 (#1783) Signed-off-by: Marco Pracucci <marco@pracucci.com>
Configuration menu - View commit details
-
Copy full SHA for a9b2f3f - Browse repository at this point
Copy the full SHA a9b2f3fView commit details -
Print version+arch of Mimir loaded to Docker. (#1793)
* Print version+arch of Mimir loaded to Docker. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> * Use debug log for distributor. Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 48fe647 - Browse repository at this point
Copy the full SHA 48fe647View commit details
Commits on May 2, 2022
-
Remove unused metrics cortex_distributor_ingester_queries_total and c…
…ortex_distributor_ingester_query_failures_total (#1797) * Remove unused metrics cortex_distributor_ingester_queries_total and cortex_distributor_ingester_query_failures_total Signed-off-by: Marco Pracucci <marco@pracucci.com> * Remove unused fields Signed-off-by: Marco Pracucci <marco@pracucci.com>
Configuration menu - View commit details
-
Copy full SHA for 9302ea6 - Browse repository at this point
Copy the full SHA 9302ea6View commit details -
Added options support to SendSumOfCountersPerUser() (#1794)
* Added options support to SendSumOfCountersPerUser() Signed-off-by: Marco Pracucci <marco@pracucci.com> * Renamed SkipZeroValueMetrics() to WithSkipZeroValueMetrics() Signed-off-by: Marco Pracucci <marco@pracucci.com>
Configuration menu - View commit details
-
Copy full SHA for fb39490 - Browse repository at this point
Copy the full SHA fb39490View commit details
Commits on May 3, 2022
-
Changed all Grafana dashboards UIDs to not conflict with Cortex ones,…
… to let people install both while migrating from Cortex to Mimir (#1801) Signed-off-by: Marco Pracucci <marco@pracucci.com>
Configuration menu - View commit details
-
Copy full SHA for 90aeee0 - Browse repository at this point
Copy the full SHA 90aeee0View commit details -
Adopt mixin convention to set dashboard UIDs based on md5(filename) (#…
…1808) Signed-off-by: Marco Pracucci <marco@pracucci.com>
Configuration menu - View commit details
-
Copy full SHA for b453b8c - Browse repository at this point
Copy the full SHA b453b8cView commit details -
Add support for store_gateway_zone args (#1807)
Allow customizing mimir cli flags per zone for the store gateway. Copied the same solution as we have for ingesters. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Configuration menu - View commit details
-
Copy full SHA for 7d278b6 - Browse repository at this point
Copy the full SHA 7d278b6View commit details
Commits on May 4, 2022
-
Add protection to store-gateway to not drop all blocks if unhealthy i…
…n the ring (#1806) * Add protection to store-gateway to not drop all blocks if unhealthy in the ring Signed-off-by: Marco Pracucci <marco@pracucci.com> * Added CHANGELOG entry Signed-off-by: Marco Pracucci <marco@pracucci.com> * Update CHANGELOG.md Co-authored-by: Peter Štibraný <pstibrany@gmail.com> Co-authored-by: Peter Štibraný <pstibrany@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for a34a384 - Browse repository at this point
Copy the full SHA a34a384View commit details -
Removed cortex_distributor_ingester_appends_total and cortex_distribu…
…tor_ingester_append_failures_total unused metrics (#1799) Signed-off-by: Marco Pracucci <marco@pracucci.com>
Configuration menu - View commit details
-
Copy full SHA for 08495fb - Browse repository at this point
Copy the full SHA 08495fbView commit details -
Remove unused clientConfig from ingester (#1814)
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Configuration menu - View commit details
-
Copy full SHA for 221caaa - Browse repository at this point
Copy the full SHA 221caaaView commit details -
Add tracing to
mimir-continuous-test
(#1795)* Extract and test TracerTransport functionality We need to use a TracerTransport in mimir-continous-test. We have that in the frontend package, but I don't want to import frontend from the mimir-continous-test, so we extract it to util/instrumentation. Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com> * Set up global tracer in mimir-continuous-test Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com> * Add tracing to the client and spans to the tests Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com> * Add jaeger-mixin to mimir-continuous test container Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com> * make license Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com> * Add traces to the write path Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com> * Update CHANGELOG.md Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
Configuration menu - View commit details
-
Copy full SHA for 286f204 - Browse repository at this point
Copy the full SHA 286f204View commit details
Commits on May 5, 2022
-
Chore: remove unused code from BucketStore (#1816)
* Removed unused Info() and advLabelSets from BucketStore Signed-off-by: Marco Pracucci <marco@pracucci.com> * Removed unused FilterConfig from BucketStore Signed-off-by: Marco Pracucci <marco@pracucci.com> * Removed unused relabelConfig from store-gateway tests Signed-off-by: Marco Pracucci <marco@pracucci.com> * Removed unused function expectedTouchedBlockOps() Signed-off-by: Marco Pracucci <marco@pracucci.com> * Removed unused recorder from BucketStore tests Signed-off-by: Marco Pracucci <marco@pracucci.com> * go mod vendor Signed-off-by: Marco Pracucci <marco@pracucci.com>
Configuration menu - View commit details
-
Copy full SHA for e926900 - Browse repository at this point
Copy the full SHA e926900View commit details -
Refactoring: force removal of all blocks when BucketStore is closed (#…
…1817) Signed-off-by: Marco Pracucci <marco@pracucci.com>
Configuration menu - View commit details
-
Copy full SHA for 24acc50 - Browse repository at this point
Copy the full SHA 24acc50View commit details -
Simplify FilterUsers() logic in store-gateway (#1819)
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Configuration menu - View commit details
-
Copy full SHA for 94bf372 - Browse repository at this point
Copy the full SHA 94bf372View commit details -
Migrate admin CSS to bootstrap 5 (#1821)
* Migrate admin CSS to bootstrap 5 When I added bootstrap, for some reason I imported bootstrap 3 which was originally launched in 2013. Before adding more CSS styles, let's migrate to modern Bootstrap 5 launched in 2021. This doesn't require an explicit jquery dependency anymore. Also re-styled admin header to adapt properly to mobile devices screens. Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com> * Update CHANGELOG.md Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
Configuration menu - View commit details
-
Copy full SHA for ac6547d - Browse repository at this point
Copy the full SHA ac6547dView commit details
Commits on May 6, 2022
-
ruler: make use of dskit
grpcclient.Config
on remote evaluation cli……ent (#1818) * ruler: use dskit grpc client for remote evaluation * addressed PR feedback
Configuration menu - View commit details
-
Copy full SHA for 59f612e - Browse repository at this point
Copy the full SHA 59f612eView commit details -
Memberlist status page CSS (#1824)
* Update CHANGELOG.md Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com> * Update dskit to 4d7238067788a04f3dd921400dcf7a7657116907 This includes changes from grafana/dskit#163 Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com> * Custom memberlist status template Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
Configuration menu - View commit details
-
Copy full SHA for e789505 - Browse repository at this point
Copy the full SHA e789505View commit details -
Configuration menu - View commit details
-
Copy full SHA for bb2f13b - Browse repository at this point
Copy the full SHA bb2f13bView commit details -
Do not drop blocks in the store-gateway if missing in the ring (#1823)
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Configuration menu - View commit details
-
Copy full SHA for 10b909b - Browse repository at this point
Copy the full SHA 10b909bView commit details -
Upgraded dskit to fix temporary partial query results when shuffle sh…
…arding is enabled and hash ring backend storage is flushed / reset (#1829) Signed-off-by: Marco Pracucci <marco@pracucci.com>
Configuration menu - View commit details
-
Copy full SHA for 3f95c81 - Browse repository at this point
Copy the full SHA 3f95c81View commit details -
Docs: ruler remote evaluation (#1714)
* include documentation for remote rule evaluation * Update docs/sources/operators-guide/configuring/configuring-to-evaluate-rules-using-query-frontend.md Co-authored-by: Ursula Kallio <ursula.kallio@grafana.com> * Update docs/sources/operators-guide/configuring/configuring-to-evaluate-rules-using-query-frontend.md Co-authored-by: Ursula Kallio <ursula.kallio@grafana.com> * Update docs/sources/operators-guide/configuring/configuring-to-evaluate-rules-using-query-frontend.md Co-authored-by: Ursula Kallio <ursula.kallio@grafana.com> * Update docs/sources/operators-guide/configuring/configuring-to-evaluate-rules-using-query-frontend.md Co-authored-by: Ursula Kallio <ursula.kallio@grafana.com> * Update docs/sources/operators-guide/configuring/configuring-to-evaluate-rules-using-query-frontend.md Co-authored-by: Ursula Kallio <ursula.kallio@grafana.com> * address PR feedback * Update docs/sources/operators-guide/architecture/components/ruler/index.md Co-authored-by: Marco Pracucci <marco@pracucci.com> * Update docs/sources/operators-guide/architecture/components/ruler/index.md Co-authored-by: Marco Pracucci <marco@pracucci.com> * Update docs/sources/operators-guide/architecture/components/ruler/index.md Co-authored-by: Marco Pracucci <marco@pracucci.com> * Update docs/sources/operators-guide/architecture/components/ruler/index.md Co-authored-by: Marco Pracucci <marco@pracucci.com> * Update docs/sources/operators-guide/architecture/components/ruler/index.md Co-authored-by: Marco Pracucci <marco@pracucci.com> * addressed PR feedback * addressed PR feedback * Update docs/sources/operators-guide/architecture/components/ruler/index.md Co-authored-by: Marco Pracucci <marco@pracucci.com> * Update docs/sources/operators-guide/running-production-environment/planning-capacity.md Co-authored-by: Marco Pracucci <marco@pracucci.com> * Update docs/sources/operators-guide/running-production-environment/planning-capacity.md Co-authored-by: Marco Pracucci <marco@pracucci.com> * addressed PR feedback Co-authored-by: Ursula Kallio <ursula.kallio@grafana.com> Co-authored-by: Marco Pracucci <marco@pracucci.com>
Configuration menu - View commit details
-
Copy full SHA for de312f1 - Browse repository at this point
Copy the full SHA de312f1View commit details
Commits on May 9, 2022
-
Alertmanager: Do not validate alertmanager configuration if it's not …
Configuration menu - View commit details
-
Copy full SHA for 00f7738 - Browse repository at this point
Copy the full SHA 00f7738View commit details
Commits on May 10, 2022
-
Alertmanager: Allow usage with
local
storage type, with appropriate…… warnings. (#1836) An oversight when we removed non-sharding modes of operation is that the `local` storage type stopped working. Unfortunately it is not conceptually simple to support this type fully, as alertmanager requires remote storage shared between all replicas, to support recovering tenant state to an arbitrary replica following an all-replica outage. To support provisioning of alerts with `local` storage, but persisting of state to remote storage, we would need to allow different storage configurations. This change fixes the issue in a more naive way, so that the alertmanager can at least be started up for testing or development purposes, but persisting state will always fail. A second PR will propose allowing the `Persister` to be disabled. Although this configuration is not recommended for production used, as long as the number of replicas is equal to the replication factor, then tenants will never move between replicas, and so the local snapshot behaviour of the upstream alertmanager will be sufficient. Fixes #1638
Configuration menu - View commit details
-
Copy full SHA for 8738cc8 - Browse repository at this point
Copy the full SHA 8738cc8View commit details
Commits on May 12, 2022
-
Mixin: Additions to Top tenants dashboard regarding sample rate and d…
…iscard rate. (#1842) Adds the following rows to the "Top tenants" dashboard: - By samples rate growth - By discarded samples rate - By discarded samples rate growth These queries are useful for determining what tenants are potentially putting excess load on distributors and ingesters (and if it increased recently).
Configuration menu - View commit details
-
Copy full SHA for 915eecd - Browse repository at this point
Copy the full SHA 915eecdView commit details
Commits on May 13, 2022
-
Use concurrent open/close operations in compactor unit tests (#1844)
Open and close files concurrently in compactor unit tests to expose bugs that implicitly rely on ordering. Exposes bugs such as prometheus/prometheus#10108 Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
Configuration menu - View commit details
-
Copy full SHA for be7a465 - Browse repository at this point
Copy the full SHA be7a465View commit details -
Mixin: Show ingestion rate limit and rule group limit on Tenants dash…
…board. (#1845) Whilst diagnosing a recent issue, we thought it would be useful to show the current ingestion rate limit for the tenant. As the limit is applied to `cortex_distributor_received_samples_total`, the limit is shown on the panel which displays this metric. ("Distributor samples received (accepted) rate"). Also added `ruler_max_rule_groups_per_tenant` while in the area. We don't currently display the number of exemplars in storage on the dashboard anywhere, so cannot add `max_global_exemplars_per_user` right now.
Configuration menu - View commit details
-
Copy full SHA for 7e31240 - Browse repository at this point
Copy the full SHA 7e31240View commit details -
Jsonnet: Preparatory refactoring to simplify deploying parallel query…
… paths. (#1846) This change extracts some of the jsonnet used to build query deployments (querier, query-scheduler, query-frontend) such that it is easier to deploy secondary query paths. The use case for this is primarily to develop a query path deployment for ruler remote-evaluation, but there may be other use cases too.
Configuration menu - View commit details
-
Copy full SHA for 720bb45 - Browse repository at this point
Copy the full SHA 720bb45View commit details
Commits on May 16, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 2076e62 - Browse repository at this point
Copy the full SHA 2076e62View commit details -
Reference 'monolithic mode' instead of 'single binary' in logs (#1847)
Signed-off-by: Marco Pracucci <marco@pracucci.com> Co-authored-by: Ursula Kallio <ursula.kallio@grafana.com> Co-authored-by: Ursula Kallio <ursula.kallio@grafana.com>
Configuration menu - View commit details
-
Copy full SHA for 5f62039 - Browse repository at this point
Copy the full SHA 5f62039View commit details -
Extend safeTemplateFilepath to cover more cases. (#1833)
* Extend safeTemplateFilepath to cover more cases. - template name ../tmpfile, stored into /tmp dir - empty template name - template name being just "." Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 718b9d9 - Browse repository at this point
Copy the full SHA 718b9d9View commit details -
Relax mimir-continuous-test pressure when deployed with Jsonnet (#1853)
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Configuration menu - View commit details
-
Copy full SHA for 93dbb1f - Browse repository at this point
Copy the full SHA 93dbb1fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0e3558c - Browse repository at this point
Copy the full SHA 0e3558cView commit details -
* Update VERSION to 2.1-rc.0 * Add relevant changelog entries for user facing PRs since mimir-2.0.0
Configuration menu - View commit details
-
Copy full SHA for 685d060 - Browse repository at this point
Copy the full SHA 685d060View commit details -
Configuration menu - View commit details
-
Copy full SHA for 373bad5 - Browse repository at this point
Copy the full SHA 373bad5View commit details
Commits on May 17, 2022
-
Configuration menu - View commit details
-
Copy full SHA for a056a35 - Browse repository at this point
Copy the full SHA a056a35View commit details -
* Create v2-1.md * Update and rename v2-1.md to v2.1.md updated the header and renamed the file. * Update v2.1.md Missing the upgrade configurations. * Update v2.1.md added bug description * Update v2.1.md bug fix writeup. * Update v2.1.md Added the series count description * Apply suggestions from code review Co-authored-by: Peter Štibraný <pstibrany@gmail.com> Co-authored-by: Marco Pracucci <marco@pracucci.com> * Update v2.1.md * Update v2.1.md updated tsdb isolation wording. * Ran make doc. * Fixed a broken relref. * Update docs/sources/release-notes/v2.1.md Co-authored-by: Peter Štibraný <pstibrany@gmail.com> Co-authored-by: Marco Pracucci <marco@pracucci.com>
Configuration menu - View commit details
-
Copy full SHA for 2a1bf20 - Browse repository at this point
Copy the full SHA 2a1bf20View commit details -
Allow custom data source regex in mixin dashboards (#1802)
* dashboards: update grafana-builder The following commit update grafana-builder version and brings in: * enable toolip by default (#665) * Add 'Data Source' label for the default datasource template variable. (#672) * add dashboard link func (#683) * make allValue configurable (#703) * Allow datasource's regex to be configured Signed-off-by: Wilfried Roset <wilfriedroset@users.noreply.github.com> * Allow custom data source regex in mixin dashboards The current dashboards offer the possibility to select a data source among all prometheus data sources in the organization. Depending on the number of data sources the list could be rather big (>10). Not all data sources host Mimir metrics as such listing them is not helpful for the users. Signed-off-by: Wilfried Roset <wilfriedroset@users.noreply.github.com> * Revert back change that was enabling shared tooltips Signed-off-by: Marco Pracucci <marco@pracucci.com> Co-authored-by: Marco Pracucci <marco@pracucci.com>
Configuration menu - View commit details
-
Copy full SHA for 25ff2b9 - Browse repository at this point
Copy the full SHA 25ff2b9View commit details -
Dashboards: Fix
container_memory_usage_bytes:sum
recording rule (#1865) * Dashboards: Fix `container_memory_usage_bytes:sum` recording rule This change causes recording rules that reference `container_memory_usage_bytes` to omit series that do not contain the required labels for rules to run successfully, by requiring a non-empty `image` label. Signed-off-by: Peter Fern <github@0xc0dedbad.com> * Update CHANGELOG Signed-off-by: Peter Fern <github@0xc0dedbad.com> * Add compiled rules Signed-off-by: Peter Fern <github@0xc0dedbad.com> Co-authored-by: Marco Pracucci <marco@pracucci.com>
Configuration menu - View commit details
-
Copy full SHA for b0ad829 - Browse repository at this point
Copy the full SHA b0ad829View commit details -
Deprecate -distributor.extend-writes and set it always to false (#1856)
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Configuration menu - View commit details
-
Copy full SHA for b096298 - Browse repository at this point
Copy the full SHA b096298View commit details -
Remove DCO from contributors guidelines (#1867)
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Configuration menu - View commit details
-
Copy full SHA for f24932d - Browse repository at this point
Copy the full SHA f24932dView commit details -
* Create v2-1.md * Update and rename v2-1.md to v2.1.md updated the header and renamed the file. * Update v2.1.md Missing the upgrade configurations. * Update v2.1.md added bug description * Update v2.1.md bug fix writeup. * Update v2.1.md Added the series count description * Apply suggestions from code review Co-authored-by: Peter Štibraný <pstibrany@gmail.com> Co-authored-by: Marco Pracucci <marco@pracucci.com> * Update v2.1.md * Update v2.1.md updated tsdb isolation wording. * Ran make doc. * Fixed a broken relref. * Update docs/sources/release-notes/v2.1.md Co-authored-by: Peter Štibraný <pstibrany@gmail.com> Co-authored-by: Marco Pracucci <marco@pracucci.com>
Configuration menu - View commit details
-
Copy full SHA for 423818a - Browse repository at this point
Copy the full SHA 423818aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5075013 - Browse repository at this point
Copy the full SHA 5075013View commit details -
Deprecate -distributor.extend-writes and set it always to false (#1856)
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Configuration menu - View commit details
-
Copy full SHA for 4eb86ed - Browse repository at this point
Copy the full SHA 4eb86edView commit details -
Configuration menu - View commit details
-
Copy full SHA for 64abe2a - Browse repository at this point
Copy the full SHA 64abe2aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6521eb9 - Browse repository at this point
Copy the full SHA 6521eb9View commit details
Commits on May 18, 2022
-
fix(mixin): add missing alertmanager hashring members (#1870)
* fix(mixin): add missing alertmanager hashring members * docs(CHANGELOG): add changelog entry
Configuration menu - View commit details
-
Copy full SHA for d9d7943 - Browse repository at this point
Copy the full SHA d9d7943View commit details -
Docs: clarify 'Set rule group' API specification (#1869)
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Configuration menu - View commit details
-
Copy full SHA for c248b4e - Browse repository at this point
Copy the full SHA c248b4eView commit details -
Simplify documentation publishing logic (#1820)
* Simplify documentation publishing logic Split into two pipelines, one that runs on main and one that runs on release branches and tags. Use `has-matching-release-tag` workflow to determine whether to release documentation on release branch and tags. `has-matching-release-tag` is documented in https://github.com/grafana/grafana-github-actions/blob/main/has-matching-release-tag/action.yaml Signed-off-by: Jack Baldry <jack.baldry@grafana.com> * Remove script no longer used for documentation releases Signed-off-by: Jack Baldry <jack.baldry@grafana.com> * Add missing clone step for the website-sync action Signed-off-by: Jack Baldry <jack.baldry@grafana.com> * Update RELEASE instructions to reflect automated docs publishing Signed-off-by: Jack Baldry <jack.baldry@grafana.com> * Remove conditional from website clone for next publishing Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
Configuration menu - View commit details
-
Copy full SHA for 5800efe - Browse repository at this point
Copy the full SHA 5800efeView commit details -
Fix capitalization of Jsonnet and Tanka (#1875)
Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
Configuration menu - View commit details
-
Copy full SHA for f4a398e - Browse repository at this point
Copy the full SHA f4a398eView commit details -
Checkout the repository as part of the documentation sync (#1876)
* Checkout the repository as part of the documentation sync I assumed this was already done but the GitHub docs confirm that it is required. https://docs.github.com/en/github-ae@latest/actions/using-workflows/about-workflows#about-workflows Signed-off-by: Jack Baldry <jack.baldry@grafana.com> * Allow manual triggering of workflow Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
Configuration menu - View commit details
-
Copy full SHA for 3cd9130 - Browse repository at this point
Copy the full SHA 3cd9130View commit details -
Fix manual workflow dispatch (#1877)
TIL that if you edit the workflow in the GitHub UI, it will lint your workflow file and make sure that all the keys conform to the schema.
Configuration menu - View commit details
-
Copy full SHA for 14caf09 - Browse repository at this point
Copy the full SHA 14caf09View commit details -
Simplify documentation publishing logic (#1820)
* Simplify documentation publishing logic Split into two pipelines, one that runs on main and one that runs on release branches and tags. Use `has-matching-release-tag` workflow to determine whether to release documentation on release branch and tags. `has-matching-release-tag` is documented in https://github.com/grafana/grafana-github-actions/blob/main/has-matching-release-tag/action.yaml Signed-off-by: Jack Baldry <jack.baldry@grafana.com> * Remove script no longer used for documentation releases Signed-off-by: Jack Baldry <jack.baldry@grafana.com> * Add missing clone step for the website-sync action Signed-off-by: Jack Baldry <jack.baldry@grafana.com> * Update RELEASE instructions to reflect automated docs publishing Signed-off-by: Jack Baldry <jack.baldry@grafana.com> * Remove conditional from website clone for next publishing Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
Configuration menu - View commit details
-
Copy full SHA for e517aa9 - Browse repository at this point
Copy the full SHA e517aa9View commit details -
Checkout the repository as part of the documentation sync (#1876)
* Checkout the repository as part of the documentation sync I assumed this was already done but the GitHub docs confirm that it is required. https://docs.github.com/en/github-ae@latest/actions/using-workflows/about-workflows#about-workflows Signed-off-by: Jack Baldry <jack.baldry@grafana.com> * Allow manual triggering of workflow Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
Configuration menu - View commit details
-
Copy full SHA for 97979f6 - Browse repository at this point
Copy the full SHA 97979f6View commit details -
Fix manual workflow dispatch (#1877)
TIL that if you edit the workflow in the GitHub UI, it will lint your workflow file and make sure that all the keys conform to the schema.
Configuration menu - View commit details
-
Copy full SHA for b66260a - Browse repository at this point
Copy the full SHA b66260aView commit details -
Chore: cleanup unused alertmanager config in Mimir jsonnet (#1873)
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Configuration menu - View commit details
-
Copy full SHA for a2a3e36 - Browse repository at this point
Copy the full SHA a2a3e36View commit details -
Update mimir-prometheus to ceaa77f1 (#1883)
* Update mimir-prometheus to ceaa77f1 This includes the fix grafana/mimir-prometheus#234 for #1866 Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com> * Update CHANGELOG.md Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com> * Fix changelog Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
Configuration menu - View commit details
-
Copy full SHA for 57216e8 - Browse repository at this point
Copy the full SHA 57216e8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8115df3 - Browse repository at this point
Copy the full SHA 8115df3View commit details
Commits on May 19, 2022
-
Increased default configuration for -server.grpc-max-recv-msg-size-by…
…tes and -server.grpc-max-send-msg-size-bytes from 4MB to 100MB (#1884) Signed-off-by: Marco Pracucci <marco@pracucci.com>
Configuration menu - View commit details
-
Copy full SHA for 74b03a6 - Browse repository at this point
Copy the full SHA 74b03a6View commit details -
Split mimir_queries rule group so that it doesn't have more than 20 r…
…ules (#1885) * Split mimir_queries rule group so that it doesn't have more than 20 rules. * Add check for number of rules in the group. Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 364c762 - Browse repository at this point
Copy the full SHA 364c762View commit details -
Add alert for store-gateways without blocks (#1882)
* Add alert for store-gateways without blocks Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * Update CHANGELOG.md Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * Clarify messages Co-authored-by: Marco Pracucci <marco@pracucci.com> * Replace "Store Gateway" with "store-gateway" Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * Rename alert to StoreGatewayNoSyncedTenants Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * Rebuild mixin Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * Update CHANGELOG.md Co-authored-by: Marco Pracucci <marco@pracucci.com> Co-authored-by: Marco Pracucci <marco@pracucci.com>
Configuration menu - View commit details
-
Copy full SHA for bcc9c89 - Browse repository at this point
Copy the full SHA bcc9c89View commit details -
Fix flaky integration tests caused by 'metric not found' (#1891)
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Configuration menu - View commit details
-
Copy full SHA for 497c09e - Browse repository at this point
Copy the full SHA 497c09eView commit details -
Docs: Explain the runtime override of active series matchers (#1868)
* Updated docs/sources/operators-guide/configuring/configuring-custom-trackers.md; made some tweaks to the examples; changed name interesting-service and also-interesting-service to service1 and service2 respectively Co-authored-by: Ursula Kallio <ursula.kallio@grafana.com> Co-authored-by: Jennifer Villa <jen.villa@grafana.com>
Configuration menu - View commit details
-
Copy full SHA for 1cc8f6d - Browse repository at this point
Copy the full SHA 1cc8f6dView commit details -
Update to latest Thanos for Memcached fixes (#1837)
Update our vendor of Thanos to pull in the most recent changes to the Memcached client. In particular, these changes prevent the client from starting many goroutines as part of batching before they are able to make progress. Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
Configuration menu - View commit details
-
Copy full SHA for 05bf2be - Browse repository at this point
Copy the full SHA 05bf2beView commit details
Commits on May 20, 2022
-
Fixed deceiving error log "failed to update cached shipped blocks aft…
…er shipper initialisation" (#1893) Signed-off-by: Marco Pracucci <marco@pracucci.com>
Configuration menu - View commit details
-
Copy full SHA for 1de5fd5 - Browse repository at this point
Copy the full SHA 1de5fd5View commit details -
Fix TestRulerEvaluationDelay flakyness (#1892)
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Configuration menu - View commit details
-
Copy full SHA for a5838ad - Browse repository at this point
Copy the full SHA a5838adView commit details -
Fix
MimirRulerMissedEvaluations
text and add playbook (#1895)* Correct magnitude on MimirRulerMissedEvaluations Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * Add playbook for MimirRulerMissedEvaluations Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * Update CHANGELOG.md Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * Remove trailing spaces Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * Update CHANGELOG.md Co-authored-by: Marco Pracucci <marco@pracucci.com> Co-authored-by: Marco Pracucci <marco@pracucci.com>
Configuration menu - View commit details
-
Copy full SHA for ac7c63d - Browse repository at this point
Copy the full SHA ac7c63dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 49f76d3 - Browse repository at this point
Copy the full SHA 49f76d3View commit details -
Use a dedicated threadpool for store-gateway requests (#1812)
Remove the use of a dedicated threadpool for index-header operations because the call overhead is prohibitively expensive. Instead, use a dedicated threadpool for entire store-gateway requests so that the cost of switching between threads is only paid a single time. This allows for isolation in the case of page faults during mmap accesses without too much overhead. Fixes #1804 Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
Configuration menu - View commit details
-
Copy full SHA for 8d0f66c - Browse repository at this point
Copy the full SHA 8d0f66cView commit details -
Upgrade consideration for active_series_custom_trackers_config (#1897)
* Upgrade consideration for active_series_custom_trackers_config * Update docs/sources/release-notes/v2.1.md Co-authored-by: Jennifer Villa <jen.villa@grafana.com> * Update docs/sources/release-notes/v2.1.md Co-authored-by: Marco Pracucci <marco@pracucci.com> Co-authored-by: Jennifer Villa <jen.villa@grafana.com>
Configuration menu - View commit details
-
Copy full SHA for 95aac32 - Browse repository at this point
Copy the full SHA 95aac32View commit details -
Upgrade consideration for active_series_custom_trackers_config (#1897)
* Upgrade consideration for active_series_custom_trackers_config * Update docs/sources/release-notes/v2.1.md Co-authored-by: Jennifer Villa <jen.villa@grafana.com> * Update docs/sources/release-notes/v2.1.md Co-authored-by: Marco Pracucci <marco@pracucci.com> Co-authored-by: Jennifer Villa <jen.villa@grafana.com>
Configuration menu - View commit details
-
Copy full SHA for 2f6fdd2 - Browse repository at this point
Copy the full SHA 2f6fdd2View commit details
Commits on May 23, 2022
-
Merge pull request #1880 from grafana/jdb/2022-05-backport-documentat…
…ion-publishing-improvements Backport documentation publishing improvements
Configuration menu - View commit details
-
Copy full SHA for 2a4b1bc - Browse repository at this point
Copy the full SHA 2a4b1bcView commit details -
fix(mixin): do not trigger TooMuchMemory alerts if no container limit…
…s are supplied (#1905) * fix(mixin): do not trigger `MimirAllocatingTooMuchMemory` or `EtcdAllocatingTooMuchMemory` alerts if no container limits are supplied * Update CHANGELOG.md Co-authored-by: Marco Pracucci <marco@pracucci.com>
Configuration menu - View commit details
-
Copy full SHA for 12929ad - Browse repository at this point
Copy the full SHA 12929adView commit details -
Fix MimirCompactorHasNotUploadedBlocks alert false positive when Mimi…
…r is deployed in monolithic mode (#1902) Signed-off-by: Marco Pracucci <marco@pracucci.com>
Configuration menu - View commit details
-
Copy full SHA for 48cae31 - Browse repository at this point
Copy the full SHA 48cae31View commit details -
Set defaults to query ingesters, not store, for recent data (#1909)
Set queriers to _not_ query storage (store-gateways) for recent data and set the store-gateways to ignore recent uncompacted blocks. Default values are set to match what we use in the Mimir jsonnet. Fixes #1639 Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
Configuration menu - View commit details
-
Copy full SHA for 0d6a400 - Browse repository at this point
Copy the full SHA 0d6a400View commit details
Commits on May 24, 2022
-
Revert distributor log level to warn in integration tests (#1910)
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Configuration menu - View commit details
-
Copy full SHA for 93b4421 - Browse repository at this point
Copy the full SHA 93b4421View commit details -
Improved error returned by -querier.query-store-after validation (#1914)
* Improved error returned by -querier.query-store-after validation Signed-off-by: Marco Pracucci <marco@pracucci.com> * Update pkg/querier/querier.go Co-authored-by: Ursula Kallio <ursula.kallio@grafana.com> Co-authored-by: Ursula Kallio <ursula.kallio@grafana.com>
Configuration menu - View commit details
-
Copy full SHA for 046ff15 - Browse repository at this point
Copy the full SHA 046ff15View commit details -
Remove jsonnet configuration settings that match default values (#1915)
* Remove jsonnet configuration settings that match default values Follow up to #1909 Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com> * Update CHANGELOG.md Co-authored-by: Marco Pracucci <marco@pracucci.com>
Configuration menu - View commit details
-
Copy full SHA for 8d7e077 - Browse repository at this point
Copy the full SHA 8d7e077View commit details -
Docs: recommend fast disks for ingesters and store-gateways (#1903)
* Docs: recommend fast disks for ingesters and store-gateways Signed-off-by: Marco Pracucci <marco@pracucci.com> * Apply suggestions from code review Co-authored-by: Ursula Kallio <ursula.kallio@grafana.com> * Update docs/sources/operators-guide/running-production-environment/production-tips/index.md Co-authored-by: Ursula Kallio <ursula.kallio@grafana.com> * Update docs/sources/operators-guide/running-production-environment/production-tips/index.md Co-authored-by: Ursula Kallio <ursula.kallio@grafana.com> Co-authored-by: Ursula Kallio <ursula.kallio@grafana.com>
Configuration menu - View commit details
-
Copy full SHA for 8a6d886 - Browse repository at this point
Copy the full SHA 8a6d886View commit details -
Improve series, sample, metadata and exemplars validation errors (#1907)
* Improved error messages returned by ValidateSample(), ValidateExemplar(), ValidateMetadata() and ValidateLabels() Signed-off-by: Marco Pracucci <marco@pracucci.com> Co-authored-by: Ursula Kallio <ursula.kallio@grafana.com> * Apply suggestions from code review Co-authored-by: Ursula Kallio <ursula.kallio@grafana.com> * Fixed unit tests after error messages edit Signed-off-by: Marco Pracucci <marco@pracucci.com> * Manually applied a suggestion to error message Signed-off-by: Marco Pracucci <marco@pracucci.com> * Renamed globalerrors pkg to singular form Signed-off-by: Marco Pracucci <marco@pracucci.com> * Cleanup globalerror package based on Oleg's feedback Signed-off-by: Marco Pracucci <marco@pracucci.com> * Removed formatting support from globalerror.ID's message generation function Signed-off-by: Marco Pracucci <marco@pracucci.com> * Changed another error message based on feedback Signed-off-by: Marco Pracucci <marco@pracucci.com> * Added CHANGELOG entry Signed-off-by: Marco Pracucci <marco@pracucci.com> * Update operations/mimir-mixin/docs/playbooks.md Co-authored-by: Ursula Kallio <ursula.kallio@grafana.com> * Rephrased label name/value length error message based on feedback received in the test file Signed-off-by: Marco Pracucci <marco@pracucci.com> * Final fixes to error messages Signed-off-by: Marco Pracucci <marco@pracucci.com> Co-authored-by: Ursula Kallio <ursula.kallio@grafana.com>
Configuration menu - View commit details
-
Copy full SHA for f02b811 - Browse repository at this point
Copy the full SHA f02b811View commit details -
mixin-tool: adapt screenshots dockerimage to support arm64 (#1916)
Signed-off-by: Miguel Ángel Ortuño <ortuman@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2bc9a79 - Browse repository at this point
Copy the full SHA 2bc9a79View commit details -
Ingester ring endpoint fix (#1918)
* /ingester/ring is also available via distributor. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> * Revert unintended change. Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for dd8418a - Browse repository at this point
Copy the full SHA dd8418aView commit details -
Configuration files for GrafanaCon 2022 presentation. (#1881)
* Configuration files for GrafanaCon 2022 presentation. Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for b06298d - Browse repository at this point
Copy the full SHA b06298dView commit details -
Update dskit to bring "Parallelize memberlist notified message proces…
…sing" PR (#1912) * Update dskit to bring "Parallelize memberlist notified message processing" PR. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> * CHANGELOG.md Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 971f5c8 - Browse repository at this point
Copy the full SHA 971f5c8View commit details -
Account for StatefulSets and Depl-s named by the helm chart (#1913)
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Configuration menu - View commit details
-
Copy full SHA for 4af57ef - Browse repository at this point
Copy the full SHA 4af57efView commit details
Commits on May 25, 2022
-
Change shuffle sharding ingester lookback default config (#1921)
* Change shuffle sharding ingester lookback default config Use the same default value for ingester lookback as the "query ingesters within" setting to reduce the number of things that need to be changed from their defaults. This change also removes use of the `-blocks-storage.tsdb.close-idle-tsdb-timeout` flag in jsonnet since the value being used matches the default. Follow up to #1915 Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com> * Changelog Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
Configuration menu - View commit details
-
Copy full SHA for 71e3e7c - Browse repository at this point
Copy the full SHA 71e3e7cView commit details -
Improved ValidateMetadata() errors (#1919)
* Improved ValidateMetadata() errors Signed-off-by: Marco Pracucci <marco@pracucci.com> * Added PR number to CHANGELOG Signed-off-by: Marco Pracucci <marco@pracucci.com> * Update pkg/util/validation/errors.go Co-authored-by: Oleg Zaytsev <mail@olegzaytsev.com> * Converted all ValidationError to be non-pointers Signed-off-by: Marco Pracucci <marco@pracucci.com> * Removed unused variable Signed-off-by: Marco Pracucci <marco@pracucci.com> * Fixed unit test Signed-off-by: Marco Pracucci <marco@pracucci.com> * Fixed markdown linter Signed-off-by: Marco Pracucci <marco@pracucci.com> Co-authored-by: Oleg Zaytsev <mail@olegzaytsev.com>
Configuration menu - View commit details
-
Copy full SHA for 45fdb3a - Browse repository at this point
Copy the full SHA 45fdb3aView commit details -
mixin/dashboards: ruler query path dashboards (#1911)
* mixin: added ruler query path dashboards Signed-off-by: Miguel Ángel Ortuño <ortuman@gmail.com> * addressed PR feedback Signed-off-by: Miguel Ángel Ortuño <ortuman@gmail.com> * docs: added ruler reads & ruler reads resources dashboard screenshots Signed-off-by: Miguel Ángel Ortuño <ortuman@gmail.com> * addressed PR feedback Signed-off-by: Miguel Ángel Ortuño <ortuman@gmail.com> * updated CHANGELOD.md Signed-off-by: Miguel Ángel Ortuño <ortuman@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 679b9d6 - Browse repository at this point
Copy the full SHA 679b9d6View commit details -
Mark query_ingesters_within and query_store_after as advanced (#1929)
* Mark query_ingesters_within and query_store_after as advanced Now that they have good defaults that match what we run in production, they shouldn't need to be tuned by users in most cases. Fixes #1924 Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com> * Update CHANGELOG.md Co-authored-by: Marco Pracucci <marco@pracucci.com> Co-authored-by: Marco Pracucci <marco@pracucci.com>
Configuration menu - View commit details
-
Copy full SHA for fde9e3e - Browse repository at this point
Copy the full SHA fde9e3eView commit details -
Remove empty chunks panel from Queries dashboard (#1928)
* Remove empty chunks panel from Queries dashboard Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * Update CHANGELOG.md Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Configuration menu - View commit details
-
Copy full SHA for 4fcbed1 - Browse repository at this point
Copy the full SHA 4fcbed1View commit details -
Make MimirGossipMembersMismatch less sensitive, and make it fire fewe…
…r alerts. (#1926) * Make MimirGossipMembersMismatch less sensitive, and make it fire fewer alerts. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> * CHANGELOG.md Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 923686a - Browse repository at this point
Copy the full SHA 923686aView commit details -
Update config value for -querier.query-ingesters-within to work with … (
#1930) * Update config value for -querier.query-ingesters-within to work with new default value for -querier.query-store-after * Remove config for -querier.query-ingesters-within as they are set to default
Configuration menu - View commit details
-
Copy full SHA for f87d288 - Browse repository at this point
Copy the full SHA f87d288View commit details -
Update Thanos vendor for memcache improvements (#1920)
Update our vendor of Thanos so that memcache keys are grouped by the server they are owned by before being split into batches. Fixes #423 Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
Configuration menu - View commit details
-
Copy full SHA for 1dcd811 - Browse repository at this point
Copy the full SHA 1dcd811View commit details -
Move usage generation to separate package (#1934)
* Move usage function into a separate package and export it Signed-off-by: Patryk Prus <patryk.prus@grafana.com> * Add function to add to flag category overrides at runtime Signed-off-by: Patryk Prus <patryk.prus@grafana.com>
Configuration menu - View commit details
-
Copy full SHA for 5f02203 - Browse repository at this point
Copy the full SHA 5f02203View commit details
Commits on May 26, 2022
-
* Add documentation about changelog scopes * update CHANGELOG for #1934
Configuration menu - View commit details
-
Copy full SHA for 46eddd3 - Browse repository at this point
Copy the full SHA 46eddd3View commit details -
Improve instance limits, ingester limits, query limiter, some querier…
… errors (#1888) * Add errors IDs to pkg/ingester/instance_limits.go Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * Add errors IDs to pkg/ingester/limiter.go Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * Add errors IDs to pkg/querier/blocks_store_queryable.go Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * Differentiate max-ingester-ingestion-rate from distributor Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * Update playbooks.md Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * Correct misspelled flags Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * Correct strings in tests as well Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * Re-iterated on ingesters limit errors Signed-off-by: Marco Pracucci <marco@pracucci.com> * Re-iterated on ingesters per-tenant limit errors Signed-off-by: Marco Pracucci <marco@pracucci.com> * Apply suggestions from code review Co-authored-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * Re-iterated on query per-tenant limit errors Signed-off-by: Marco Pracucci <marco@pracucci.com> * Added PR number to CHANGELOG entry Signed-off-by: Marco Pracucci <marco@pracucci.com> * Apply suggestions from code review Co-authored-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * Mention the cardinality API endpoint in the err-mimir-max-series-per-metric runbook Signed-off-by: Marco Pracucci <marco@pracucci.com> * Update operations/mimir-mixin/docs/playbooks.md Co-authored-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * Fixed InstanceLimits receiver name to be consistent Signed-off-by: Marco Pracucci <marco@pracucci.com> * Clarify metadata is stored in memory Signed-off-by: Marco Pracucci <marco@pracucci.com> * Fixed linter and tests Signed-off-by: Marco Pracucci <marco@pracucci.com> * Fixed more tests Signed-off-by: Marco Pracucci <marco@pracucci.com> * Update pkg/querier/blocks_store_queryable.go Co-authored-by: Oleg Zaytsev <mail@olegzaytsev.com> * Fix english grammar about 'how to fix it' Signed-off-by: Marco Pracucci <marco@pracucci.com> Co-authored-by: Marco Pracucci <marco@pracucci.com> Co-authored-by: Oleg Zaytsev <mail@olegzaytsev.com>
Configuration menu - View commit details
-
Copy full SHA for 4a624a0 - Browse repository at this point
Copy the full SHA 4a624a0View commit details -
make ingesters use heartbeat timeout instead of period to fix the bug… (
#1933) * make ingesters use heartbeat timeout instead of period to fix the bug where they sometimes appear as unhealthy * Update CHANGELOG.md Co-authored-by: Marco Pracucci <marco@pracucci.com>
Configuration menu - View commit details
-
Copy full SHA for 98df41b - Browse repository at this point
Copy the full SHA 98df41bView commit details -
Configuration menu - View commit details
-
Copy full SHA for f35f74f - Browse repository at this point
Copy the full SHA f35f74fView commit details -
Update dashboard screenshots (#1940)
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Configuration menu - View commit details
-
Copy full SHA for 7c87ee7 - Browse repository at this point
Copy the full SHA 7c87ee7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 840c686 - Browse repository at this point
Copy the full SHA 840c686View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4118aa8 - Browse repository at this point
Copy the full SHA 4118aa8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6007bd9 - Browse repository at this point
Copy the full SHA 6007bd9View commit details -
Merge pull request #1941 from grafana/merge-release-2.1-to-main
Merge release 2.1 to main
Configuration menu - View commit details
-
Copy full SHA for 52c1036 - Browse repository at this point
Copy the full SHA 52c1036View commit details -
Add minimum Grafana version to mixin dashboards (#1943)
Signed-off-by: Patrick Oyarzun <patrick.oyarzun@grafana.com>
Configuration menu - View commit details
-
Copy full SHA for a41263e - Browse repository at this point
Copy the full SHA a41263eView commit details -
Configuration menu - View commit details
-
Copy full SHA for ec514d5 - Browse repository at this point
Copy the full SHA ec514d5View commit details
Commits on May 30, 2022
-
Chore: renamed source files for remote ruler dashboards (#1937)
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Configuration menu - View commit details
-
Copy full SHA for 3ace949 - Browse repository at this point
Copy the full SHA 3ace949View commit details -
Move the mimir-distributed helm chart into the mimir repository (#1925)
* Initial copy of mimir-distributed helm chart This commit is not expected to work in CI. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> * Update github action for helm lint and test Set the working directory for github actions for helm actions. Set more consistent name for github actions. Set chart name for testing. Ignore generated helm doc from prettier. Do not do release for now of helm chart. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Configuration menu - View commit details
-
Copy full SHA for d5601a1 - Browse repository at this point
Copy the full SHA d5601a1View commit details -
Add bucket prefix configuration (#1686)
* Add bucket prefix configuration Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * Add allowed chars validation for storage prefix Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * Add unit tests for PrefixedBucketClient Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * Add CHANGELOG entry Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * Use grafana/regexp instead of regexp Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * Improve validation of storage_prefix Update docs and add validate for .. and . Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * Add some tests for AM and ruler bucket validaiton Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * Add tests for bucket prefix with filesystem client Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * Update helm text too Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * Update everything Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * Simplify validation for storage_prefix Only accept alphanumeric characters for the storage_prefix to prevent mistypings and misunderstandings when the prefix ends with a slash or contains slashes and dots Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * Update CHANGELOG.md Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * Make stronger assertions in bucket validation test Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * Make stronger assertions in bucket prefix test Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * Assert on errors, not on strings Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * Exclude YAML field names from error message Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Configuration menu - View commit details
-
Copy full SHA for 7aa6015 - Browse repository at this point
Copy the full SHA 7aa6015View commit details -
Include full image tag on rollout dashboard (#1932)
* Make version matcher in rollout dashboard work for non-weekly images Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * Add CHANGELOG.md entry Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * Update CHANGELOG.md Co-authored-by: Marco Pracucci <marco@pracucci.com>
Configuration menu - View commit details
-
Copy full SHA for 0635166 - Browse repository at this point
Copy the full SHA 0635166View commit details -
docs: move federated rule groups documentation to its own section (#1906
Configuration menu - View commit details
-
Copy full SHA for 144c76d - Browse repository at this point
Copy the full SHA 144c76dView commit details -
Make networking panels pod matchers work with helm chart (#1927)
* Make networking panels pod matchers work with helm chart The pods created by the helm chart follow a format of <helm_release_name>-mimir-<ingester|distributor|...>. This is a problem for all places that use the per_instance_label for matching. The per_instance_label is mostly used in aggregations (sum by (pod), count by (pod), ...). The networking panels are the only ones that use it for matching. Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * Replace .* with a stronger regex in pod matchers Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * Add CHANGELOG.md entry Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Configuration menu - View commit details
-
Copy full SHA for 7f41774 - Browse repository at this point
Copy the full SHA 7f41774View commit details -
Add max query length error to errors catalog (#1939)
* Add max query length error to errors catalogue Signed-off-by: Marco Pracucci <marco@pracucci.com> * Added PR number to CHANGELOG entry Signed-off-by: Marco Pracucci <marco@pracucci.com> * Apply suggestions from code review Co-authored-by: Ursula Kallio <ursula.kallio@grafana.com> Co-authored-by: Ursula Kallio <ursula.kallio@grafana.com>
Configuration menu - View commit details
-
Copy full SHA for 9dcf6db - Browse repository at this point
Copy the full SHA 9dcf6dbView commit details -
Remove image spec from demo file. (#1946)
* Remove image spec from demo file. Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 99b964b - Browse repository at this point
Copy the full SHA 99b964bView commit details -
Fix rejected identity accept encoding (#1864)
* Fix rejected identity accept-encoding When a request comes in with header: Accept-Encoding: gzip;q=1, identity;q=0 we should gzip the response even if it's smaller than the defined minimum size. We achieve this by fixing the github.com/nytimes/gziphandler code, and bringing the fixed code into this repository since: - they don't seem to be maintaining it anymore - we don't want to use a replace directive as it's very likely to be lost in codebases depending on this. - it's a little amount of code (500 lines) Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com> * Add API test for gzip Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com> * make lint pkg/util/gziphandler Mostly handling errors, also removed the deprecated http.CloseNotifier functionality and related code. Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com> * Update CHANGELOG.md Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com> * Fix comment Co-authored-by: Marco Pracucci <marco@pracucci.com> * Add faillint for github.com/nytimes/gziphandler Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com> * make lint Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com> * Fix faillint paths Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com> * If there's content-encoding, start plain write Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com> * If less than min-size, don't encode Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com> * Refactor `handleContentType` to handle by default Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com> * Rename acceptsIdentity to rejectsIdentity, Hopefully this will minimise the amount of double negations making the code clearer. Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com> * Fix comment Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com> Co-authored-by: Marco Pracucci <marco@pracucci.com>
Configuration menu - View commit details
-
Copy full SHA for 2560efd - Browse repository at this point
Copy the full SHA 2560efdView commit details -
Distributor: added per-tenant request limit (#1843)
* distributor: added request limiter logic Signed-off-by: Miguel Ángel Ortuño <ortuman@gmail.com> * updated CHANGELOG.md * addressed PR feedback Signed-off-by: Miguel Ángel Ortuño <ortuman@gmail.com> * distributor: added type plans rate limits Assuming a minimum sane value of 100 samples per request, we've set default request limits for each user tier. * docs: added request limit distributor documentation * rebuilt jsonnet test output * make linter happy * addressed PR feedback Signed-off-by: Miguel Ángel Ortuño <ortuman@gmail.com> * addressed PR feedback Signed-off-by: Miguel Ángel Ortuño <ortuman@gmail.com> * addressed PR feedback Signed-off-by: Miguel Ángel Ortuño <ortuman@gmail.com> * addressed PR feedback Signed-off-by: Miguel Ángel Ortuño <ortuman@gmail.com> * updated reference help Signed-off-by: Miguel Ángel Ortuño <ortuman@gmail.com> * addressed PR feedback Signed-off-by: Miguel Ángel Ortuño <ortuman@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for b21bcfc - Browse repository at this point
Copy the full SHA b21bcfcView commit details -
Add bucket prefix to experimental features (#1951)
* Add bucket prefix to experimental features Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * Update flag status of storage_prefix to experimental Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Configuration menu - View commit details
-
Copy full SHA for d6de837 - Browse repository at this point
Copy the full SHA d6de837View commit details
Commits on May 31, 2022
-
* Copy shipper from Thanos. * Remove support for uploading compacted blocks. * Always allow out-of-order uploads. Removed unused overlap checker. * Rename Shipper interface to BlocksUploader, and ThanosShipper to Shipper. * Extract readShippedBlocks method from user_tsdb.go * Added shipper unit tests (copied and adapted from original tests) * Add faillint rule to avoid using Thanos shipper. Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0772991 - Browse repository at this point
Copy the full SHA 0772991View commit details -
Adjust the name of the tag expected by documentation publishing (#1974)
Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
Configuration menu - View commit details
-
Copy full SHA for 7384937 - Browse repository at this point
Copy the full SHA 7384937View commit details -
Use github.com/colega/grafana-tools-sdk fork (#1973)
* Use github.com/colega/grafana-tools-sdk fork See grafana/cortex-tools#248 for more context (this is the same change). The grafana-tools/sdk dependency will eventually be removed entirely from analyse commands. Signed-off-by: hjet <hjet@users.noreply.github.com> * Update CHANGELOG.md Signed-off-by: hjet <hjet@users.noreply.github.com> * mod tidy
Configuration menu - View commit details
-
Copy full SHA for fc83295 - Browse repository at this point
Copy the full SHA fc83295View commit details
Commits on Jun 1, 2022
-
Deprecate -ingester.ring.join-after (#1965)
* Deprecate -ingester.ring.join-after Signed-off-by: Marco Pracucci <marco@pracucci.com> * Addressed review feedback Signed-off-by: Marco Pracucci <marco@pracucci.com>
Configuration menu - View commit details
-
Copy full SHA for fae0534 - Browse repository at this point
Copy the full SHA fae0534View commit details -
Dashboards: disable gateway panels by default (#1955)
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Configuration menu - View commit details
-
Copy full SHA for ca74607 - Browse repository at this point
Copy the full SHA ca74607View commit details -
Docs: rename 'playbooks' to 'runbooks' and move them to doc (#1970)
* Docs: rename 'playbooks' to 'runbooks' and move them to doc Signed-off-by: Marco Pracucci <marco@pracucci.com> * Named runbooks folder as 'mimir-runbooks/' to make it easy to import in Grafana Labs internal infrastructure as code Signed-off-by: Marco Pracucci <marco@pracucci.com> * Fix anchors check because they're case insensitive Signed-off-by: Marco Pracucci <marco@pracucci.com> * Apply suggestions from code review Co-authored-by: Ursula Kallio <ursula.kallio@grafana.com> Co-authored-by: Ursula Kallio <ursula.kallio@grafana.com>
Configuration menu - View commit details
-
Copy full SHA for 951a69b - Browse repository at this point
Copy the full SHA 951a69bView commit details -
Preparation of e2eutils for Thanos indexheader unit tests. (#1982)
We want to pull in the indexheader package from Thanos so that we can add some experimental alternative implementations of BinaryReader. In order to also pull in the unit tests for this package, we need the replacements for e2eutil.Copy and e2eutil.CreateBlock. This change does two things: 1. Copy in e2eutil/copy.go and fix it up accordingly. 2. Move CreateBlock into a package to avoid circular imports.
Configuration menu - View commit details
-
Copy full SHA for 4a870e2 - Browse repository at this point
Copy the full SHA 4a870e2View commit details -
Make propagation of forwarding errors configurable (#1978)
* make propagation of forwarding errors optional Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com> * add test for disabled error propagation Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com> * leave error propagation enabled by default Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com> * update help Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com> * update docs * better wording Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for a0351ed - Browse repository at this point
Copy the full SHA a0351edView commit details -
Release the mimir-distributed-beta helm chart (#1948)
Use the common workflow from the helm-chart repo. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Configuration menu - View commit details
-
Copy full SHA for 205ead3 - Browse repository at this point
Copy the full SHA 205ead3View commit details -
Copy Thanos block/indexheader package (#1983)
* Copy thanos/pkg/block/indexheader. * Update provenance. * Fix linter error due to error variable name. * Use require instead of e2eutil. * Replace usage of e2eutil.Copy * Replace usage of e2eutil.CreateBlock with local version. * Replace use of Thanos indexheader with local copy. * Add faillint check for upstream indexheader. * Fix goleak ignore for NewReaderPool. * Update vendor directory.
Configuration menu - View commit details
-
Copy full SHA for 8f278a3 - Browse repository at this point
Copy the full SHA 8f278a3View commit details -
Prepare mimir beta chart release (#1995)
* Rename chart back to mimir-distributed Apparently the helm option --devel is needed to trigger using beta versions. This should be enough protection for accidental use. Avoids renaming issues. * Version bump helm chart Do version bump to a beta version but nothing else until we double check that such beta chart cannot be accidentally selected with helm tooling. * Enable helm chart release from main branch Release process tested ok on test branch. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Configuration menu - View commit details
-
Copy full SHA for 78ea76b - Browse repository at this point
Copy the full SHA 78ea76bView commit details -
Bump version of helm chart (#1996)
Test if helm release triggers correctly. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Configuration menu - View commit details
-
Copy full SHA for 017122b - Browse repository at this point
Copy the full SHA 017122bView commit details
Commits on Jun 2, 2022
-
Update gopkg.in/yaml.v3 (#1989)
This updates to a version that contains the fix to CVE-2022-28948.
Configuration menu - View commit details
-
Copy full SHA for 6603370 - Browse repository at this point
Copy the full SHA 6603370View commit details -
Remove hardlinking in Shipper code. (#1969)
* Remove hardlinking in Shipper code. Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2c2c65d - Browse repository at this point
Copy the full SHA 2c2c65dView commit details -
[helm] use grpc round robin for distributor clients (#1991)
* Use GRPC round-robin for gateway -> distributor requests Fixes #1987 Update chart version and changelog Use the headless distributor service for the nginx gateway Signed-off-by: Patrick Oyarzun <patrick.oyarzun@grafana.com>
Configuration menu - View commit details
-
Copy full SHA for 8362bee - Browse repository at this point
Copy the full SHA 8362beeView commit details -
Fix binary_reader.go header text. (#1999)
Mistakenly left two lines when updating the provenance for the file.
Configuration menu - View commit details
-
Copy full SHA for 3c27d4f - Browse repository at this point
Copy the full SHA 3c27d4fView commit details -
Workaround to keep using old memcached bitnami chart for now (#1998)
* Workaround to keep using old memcached bitnami chart for now See also: grafana/helm-charts#1438 Also clean up unused chart repositories from ct.yaml. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> Co-authored-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Configuration menu - View commit details
-
Copy full SHA for 85a0fb2 - Browse repository at this point
Copy the full SHA 85a0fb2View commit details -
[helm] add results cache (#1993)
* [helm] Add query-frontend results cache Fixes grafana/helm-charts#1403 * Add PR to CHANGELOG Signed-off-by: Patrick Oyarzun <patrick.oyarzun@grafana.com> * Fix README Signed-off-by: Patrick Oyarzun <patrick.oyarzun@grafana.com>
Configuration menu - View commit details
-
Copy full SHA for 81e9935 - Browse repository at this point
Copy the full SHA 81e9935View commit details -
Disable distributor.extend-writes & ingester.ring.unregister-on-shutd…
…own (#1994) Signed-off-by: Patrick Oyarzun <patrick.oyarzun@grafana.com>
Configuration menu - View commit details
-
Copy full SHA for 58ff0d1 - Browse repository at this point
Copy the full SHA 58ff0d1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4d0a447 - Browse repository at this point
Copy the full SHA 4d0a447View commit details -
[helm] Prepare image bump for 2.1 release (#2001)
* Prepare image bump for 2.1 release Signed-off-by: Patrick Oyarzun <patrick.oyarzun@grafana.com> * Fix README template to reference 2.1 Signed-off-by: Patrick Oyarzun <patrick.oyarzun@grafana.com> * Add nice link text to CHANGELOG Signed-off-by: Patrick Oyarzun <patrick.oyarzun@grafana.com> * Update CHANGELOG.md
Configuration menu - View commit details
-
Copy full SHA for 4186478 - Browse repository at this point
Copy the full SHA 4186478View commit details -
Configuration menu - View commit details
-
Copy full SHA for a8b1648 - Browse repository at this point
Copy the full SHA a8b1648View commit details
Commits on Jun 3, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 8bc28f1 - Browse repository at this point
Copy the full SHA 8bc28f1View commit details -
Replace hardcoded intervals with $__rate_interval in dashboards (#2011)
* Replace hardcoded intervals with $__rate_interval in dashboards Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * Add CHANGELOG.md entry Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Configuration menu - View commit details
-
Copy full SHA for b631551 - Browse repository at this point
Copy the full SHA b631551View commit details -
Standardise error messages for distributor instance limits (#1984)
* standardise error messages for distributor instance limits * Apply suggestions from code review Co-authored-by: Marco Pracucci <marco@pracucci.com> * Apply suggestions from code review Co-authored-by: Ursula Kallio <ursula.kallio@grafana.com> * apply code review suggestions to rest of doc for consistency * manually apply suggestion from code review Co-authored-by: Marco Pracucci <marco@pracucci.com> Co-authored-by: Ursula Kallio <ursula.kallio@grafana.com>
Configuration menu - View commit details
-
Copy full SHA for d4c0f37 - Browse repository at this point
Copy the full SHA d4c0f37View commit details -
Remove tutorials/ symlink (#2007)
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Configuration menu - View commit details
-
Copy full SHA for c3b87b7 - Browse repository at this point
Copy the full SHA c3b87b7View commit details -
Add querier autoscaler support to jsonnet (#2013)
* Add querier autoscaler support to jsonnet Signed-off-by: Marco Pracucci <marco@pracucci.com> * Fixed autoscaling.libsonnet import Signed-off-by: Marco Pracucci <marco@pracucci.com>
Configuration menu - View commit details
-
Copy full SHA for 7f462dd - Browse repository at this point
Copy the full SHA 7f462ddView commit details -
Add a check to Mimir jsonnet to ensure query-scheduler is enabled whe…
…n enabling querier autoscaling (#2023) * Add a check to Mimir jsonnet to ensure query-scheduler is enabled when enabling querier autoscaling Signed-off-by: Marco Pracucci <marco@pracucci.com> * Shouldn't be an exported object Signed-off-by: Marco Pracucci <marco@pracucci.com>
Configuration menu - View commit details
-
Copy full SHA for 7a4b40a - Browse repository at this point
Copy the full SHA 7a4b40aView commit details -
Don't include external labels in blocks uploaded by Ingester (#1972)
* Remove support for external labels. * Fixed comments. * Don't use TenantID label. Filter out the label during compaction. * CHANGELOG.md * Use public function from Thanos. * Use new UploadBlock function, move GrpcContextMetadataTenantID constant. * Rename tsdb2 import to mimir_tsdb. * Fix tests. Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 8bff6d0 - Browse repository at this point
Copy the full SHA 8bff6d0View commit details -
Enhance MimirRequestLatency runbook with more advice (#1967)
* Enhance MimirRequestLatency runbook with more advice Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> Co-authored-by: Marco Pracucci <marco@pracucci.com>
Configuration menu - View commit details
-
Copy full SHA for 0088e48 - Browse repository at this point
Copy the full SHA 0088e48View commit details -
Include helm-docs in build and CI (#2026)
* Update the mimir build image and its build doc Dockerfile: Add helm-docs package to the image. how-to: Write down the requirements for build in more detail. Add information about build on linux. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> * Expand make doc with helm-docs command This enables generating the helm chart README with the same make doc command as all other documentation. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> * Update docs/internal/how-to-update-the-build-image.md Co-authored-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Configuration menu - View commit details
-
Copy full SHA for c25a9a5 - Browse repository at this point
Copy the full SHA c25a9a5View commit details
Commits on Jun 4, 2022
-
Update contributing guides for the helm chart (#2008)
* Update contributing guides for the helm chart Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> * Turn off helm version increment check in CI This enables periodic releases, as opposed to requiring version bump for release at every PR. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Configuration menu - View commit details
-
Copy full SHA for 591f694 - Browse repository at this point
Copy the full SHA 591f694View commit details -
Add extraEnvFrom to all services and enable injection into mimir conf…
…ig (#2017) Add `extraEnvFrom` capability to all Mimir services to enable injecting secrets via environment variables. Enable `-config.exand-env=true` option in all Mimir services to be able to take secrets/settings from the environment and inject them into the Mimir configuration file. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Configuration menu - View commit details
-
Copy full SHA for cfe513d - Browse repository at this point
Copy the full SHA cfe513dView commit details
Commits on Jun 6, 2022
-
Docs: fix mimir-mixin installation instructions (#2015)
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Configuration menu - View commit details
-
Copy full SHA for 12a4e81 - Browse repository at this point
Copy the full SHA 12a4e81View commit details -
Docs: make documentation a first class citizen in CHANGELOG (#2025)
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Configuration menu - View commit details
-
Copy full SHA for 4a5df42 - Browse repository at this point
Copy the full SHA 4a5df42View commit details -
Helm: add global.extraEnv and global.extraEnvFrom (#2031)
* Helm: add global.extraEnv and global.extraEnvFrom Enables setting environment and env injection in one place for mimir + nginx. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Configuration menu - View commit details
-
Copy full SHA for e6c2187 - Browse repository at this point
Copy the full SHA e6c2187View commit details -
Upgrade alpine to 3.16.0 (#2028)
* Upgrade alpine to 3.16.0 * Enhance MimirRequestLatency runbook with more advice (#1967) * Enhance MimirRequestLatency runbook with more advice Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> Co-authored-by: Marco Pracucci <marco@pracucci.com> * Include helm-docs in build and CI (#2026) * Update the mimir build image and its build doc Dockerfile: Add helm-docs package to the image. how-to: Write down the requirements for build in more detail. Add information about build on linux. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> * Expand make doc with helm-docs command This enables generating the helm chart README with the same make doc command as all other documentation. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> * Update docs/internal/how-to-update-the-build-image.md Co-authored-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * Update contributing guides for the helm chart (#2008) * Update contributing guides for the helm chart Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> * Turn off helm version increment check in CI This enables periodic releases, as opposed to requiring version bump for release at every PR. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> * Add extraEnvFrom to all services and enable injection into mimir config (#2017) Add `extraEnvFrom` capability to all Mimir services to enable injecting secrets via environment variables. Enable `-config.exand-env=true` option in all Mimir services to be able to take secrets/settings from the environment and inject them into the Mimir configuration file. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> * Docs: fix mimir-mixin installation instructions (#2015) Signed-off-by: Marco Pracucci <marco@pracucci.com> * Docs: make documentation a first class citizen in CHANGELOG (#2025) Signed-off-by: Marco Pracucci <marco@pracucci.com> * upgrade to alpine 3.16.0 * upgrade alpine to 3.16.0 Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com> Co-authored-by: Marco Pracucci <marco@pracucci.com> Co-authored-by: George Krajcsovits <krajorama@users.noreply.github.com> Co-authored-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Configuration menu - View commit details
-
Copy full SHA for 322894e - Browse repository at this point
Copy the full SHA 322894eView commit details -
Helm: release our first weekly (#2033)
This should be automated, but now done manually. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Configuration menu - View commit details
-
Copy full SHA for e34522b - Browse repository at this point
Copy the full SHA e34522bView commit details -
Set memcache chunks cache timeout to 450ms (#2035)
The default value, shared with all other memcache caches, of 200ms is too aggressive in most cases. This results in TSDB data often being fetched from object storage in cases where a slighly longer timeout would result in a cache hit. This is set in Jsonnet and Helm instead of as a default of the CLI flag since the flags (and hence their defaults) are shared among all caches (index, chunks, metadata, results). Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
Configuration menu - View commit details
-
Copy full SHA for 631126f - Browse repository at this point
Copy the full SHA 631126fView commit details -
[helm] Add test-enterprise for Helm CI (#2027)
* Add test-enterprise-values.yaml
Configuration menu - View commit details
-
Copy full SHA for a76e296 - Browse repository at this point
Copy the full SHA a76e296View commit details
Commits on Jun 7, 2022
-
Fix panic at startup when Mimir is running in monolithic mode and que…
…ry sharding is enabled (#2036) Signed-off-by: Marco Pracucci <marco@pracucci.com>
Configuration menu - View commit details
-
Copy full SHA for 66fb82f - Browse repository at this point
Copy the full SHA 66fb82fView commit details -
Chore: remove obsolete comment from jsonnet (#2038)
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Configuration menu - View commit details
-
Copy full SHA for c492cb8 - Browse repository at this point
Copy the full SHA c492cb8View commit details -
Chore: introduced newDiscoveryService() util in jsonnet (#2037)
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Configuration menu - View commit details
-
Copy full SHA for b49fe67 - Browse repository at this point
Copy the full SHA b49fe67View commit details -
Chore: add some jsonnet utilities to reduce code duplication (#2039)
* Renamed newDiscoveryService() to newMimirDiscoveryService() Signed-off-by: Marco Pracucci <marco@pracucci.com> * Added newMimirPdb() utility Signed-off-by: Marco Pracucci <marco@pracucci.com> * Added newMimirStatefulSet() utility Signed-off-by: Marco Pracucci <marco@pracucci.com>
Configuration menu - View commit details
-
Copy full SHA for 8415eb1 - Browse repository at this point
Copy the full SHA 8415eb1View commit details -
Add a helm golden record (#2034)
* Helm: Add golden-record build script * Helm: add test-values golden record * Add PR check for `check-helm-tests` * Add Helm setup to lint-helm action * Update generated helm tests * Fix bash linting * Update contribution guidelines * Update generated helm manifests * Helm: fix kube version Set kubeVersionOverride to generate PodDisruptionBudget API version consistently. When I ran the test, I got a diff, because my k8s is newer (1.23). Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> * Update operations/helm/tests/build.sh Co-authored-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> Co-authored-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Configuration menu - View commit details
-
Copy full SHA for 84e4901 - Browse repository at this point
Copy the full SHA 84e4901View commit details -
Store Gateway: Add experimental configuration to use MAP_POPULATE for…
… indexheader reads. (#2019) Introduces a new experimental configuration option (`-blocks-storage.bucket-store.index-header.map-populate-enabled`). This enables the use of the `MAP_POPULATE` flag when `mmap`-ing index-header files in the store-gateway. What this flag does is advise the kernel to (synchronously) pre-fault all pages in the memory region, loading them into the file system cache. Why is this a good idea? - The initial read process of the index-header files has shown to cause hangups in the store-gateway. - By using this option, I/O is done in the mmap() syscall, which the Go scheduler can cope with. - We reduce the likelyhood of Goroutines getting stalled in major page faults. - The initial read process walks the entire file anyway, so we are not doing any more I/O. - It's a very low risk change compared to re-writing the BinaryReader (work in progress). Why is this not perfect? - The Kernel does not guarantee the pages will stay in memory, so we are only reducing the probability of major page faults. Rationale about the implementation: - I have copied the mmap utilities from Prometheus as a temporary measure, for the sake of evaluating this change.
Configuration menu - View commit details
-
Copy full SHA for 6b5cc6a - Browse repository at this point
Copy the full SHA 6b5cc6aView commit details
Commits on Jun 8, 2022
-
Initialize Tanka with k8s-libsonnet v1.21. (#2051)
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 44463cf - Browse repository at this point
Copy the full SHA 44463cfView commit details -
Update Prometheus with async chunk mapper changes. (#2043)
* Update Prometheus with async chunk mapper changes. Included changes: grafana/mimir-prometheus#131 grafana/mimir-prometheus#247 These result is lower memory usage by chunk mapper. Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for e6e5dd3 - Browse repository at this point
Copy the full SHA e6e5dd3View commit details -
Fix ruler config in getting started guide (#2052)
* Fix ruler config in getting started guide Signed-off-by: Marco Pracucci <marco@pracucci.com> * Added CHANGELOG entry Signed-off-by: Marco Pracucci <marco@pracucci.com>
Configuration menu - View commit details
-
Copy full SHA for fa28ccf - Browse repository at this point
Copy the full SHA fa28ccfView commit details -
Fix build for darwin platform. (#2054)
A previous change (#2019) assumed MAP_POPULATE was available on Darwin. This fixes the build.
Configuration menu - View commit details
-
Copy full SHA for 1d7da8f - Browse repository at this point
Copy the full SHA 1d7da8fView commit details -
mixin: adapt alerts/playbooks to consider ruler query path components (…
…#1949) * mixin: adapt alerts/playbooks to have into consideration ruler query path components. Signed-off-by: Miguel Ángel Ortuño <ortuman@gmail.com> * applied PR suggestion Signed-off-by: Miguel Ángel Ortuño <ortuman@gmail.com> * applied PR suggestion Signed-off-by: Miguel Ángel Ortuño <ortuman@gmail.com> * restored ruler missed evaluations alert Signed-off-by: Miguel Ángel Ortuño <ortuman@gmail.com> * updated CHANGELOG.md Signed-off-by: Miguel Ángel Ortuño <ortuman@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for dd1c12a - Browse repository at this point
Copy the full SHA dd1c12aView commit details -
Return and log detailed services information on /ready (#2055)
* Return and log detailed services information on /ready This helps debug starting services more easily. Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * Only return non-running services Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Configuration menu - View commit details
-
Copy full SHA for 716d0c6 - Browse repository at this point
Copy the full SHA 716d0c6View commit details -
Add validation.RateLimited and TooManyHAClusters to errors catalogue (#…
…2009) * add validation.RateLimited to error catalogue * Add validation.TooManyHAClusters to error catalogue * update docs * Apply suggestions from code review Co-authored-by: Marco Pracucci <marco@pracucci.com> * improve new MessageWithLimitConfig and add tests * Apply suggestions from code review Co-authored-by: Marco Pracucci <marco@pracucci.com> * Update from changes in code review Co-authored-by: Marco Pracucci <marco@pracucci.com>
Configuration menu - View commit details
-
Copy full SHA for eb812fd - Browse repository at this point
Copy the full SHA eb812fdView commit details -
Add Patrick Oyarzun as Team Member (#2057)
* Add Patrick Oyarzun as Team Member * Update MAINTAINERS.md
Configuration menu - View commit details
-
Copy full SHA for c95c61f - Browse repository at this point
Copy the full SHA c95c61fView commit details -
mimir-continuous-test: Add smoke test mode (#2047)
* mimir-continuous-test: Add smoke test mode * Add PR number to CHANGELOG * Update error assertions in write_read_series_test * Fix doc formatting * Address PR feedback * Fix goimports formatting
Configuration menu - View commit details
-
Copy full SHA for 29142fc - Browse repository at this point
Copy the full SHA 29142fcView commit details
Commits on Jun 9, 2022
-
Jsonnet: add compactor service (#2063)
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Configuration menu - View commit details
-
Copy full SHA for 807f09e - Browse repository at this point
Copy the full SHA 807f09eView commit details -
Tidy up code and names for errors catalogue (#2056)
* Make MessageWithLimitConfig accept multiple flags * Add tenant string in per-tenant error labels * Revert "Add tenant string in per-tenant error labels" This reverts commit 758ef72. * rename error too-many-ha-clusters
Configuration menu - View commit details
-
Copy full SHA for 4076f4a - Browse repository at this point
Copy the full SHA 4076f4aView commit details -
ruler: report failed eval on any 5xx status (#2053)
* ruler: report failed eval on any 5xx status Signed-off-by: Miguel Ángel Ortuño <ortuman@gmail.com> * addressed PR suggestion Signed-off-by: Miguel Ángel Ortuño <ortuman@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for e17cb56 - Browse repository at this point
Copy the full SHA e17cb56View commit details
Commits on Jun 10, 2022
-
Configuration menu - View commit details
-
Copy full SHA for e4ef7db - Browse repository at this point
Copy the full SHA e4ef7dbView commit details -
Replace thanos dependency with a custom commit
The OOO implementation changed the ChunkReader interface. Mimir imports Thanos and there are issues with the changes on that interface so we had to fork Thanos to perform the interface change. We'll try to upstream this soon enough so that we dont need to do this in the future.
Configuration menu - View commit details
-
Copy full SHA for a2bb750 - Browse repository at this point
Copy the full SHA a2bb750View commit details