This repository was archived by the owner on Jul 19, 2023. It is now read-only.
Datasource: Allow editor to shrink #227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aocenas
commented
Sep 14, 2022
| // Not exactly sure but without this the editor doe not shrink after resizing (so you can make it bigger but not | ||
| // smaller). At the same time this does not actually make the editor 100px because it has flex 1 so I assume | ||
| // this should sort of act as a flex-basis (but flex-basis does not work for this). So yeah CSS magic. | ||
| width: 100px; |
There was a problem hiding this comment.
@gabor I really tried to just copy all the Prometheus code here but that still did not help. I tried this by accident and it works. So just FYI no idea why.
There was a problem hiding this comment.
There was a problem hiding this comment.
wow, that's strange.. so if you use the prometheus-code then it does not work, but if you add this it works.. sorry, no idea... maybe the prometheus-datasource has some parent-component-css that does this? i'm just glad it was somehow made work :)
simonswine
pushed a commit
to simonswine/pyroscope
that referenced
this pull request
Jun 30, 2023
…/allow-editor-shrink Datasource: Allow editor to shrink
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #186
For some reason some combination of monaco and CSS made it grow-only.
Peek.2022-09-14.17-46.mp4
Honestly the fix here is weird and I am not really sure why it helped.