-
Notifications
You must be signed in to change notification settings - Fork 34
Eslint Plugin: fix broken download paths #2208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉 but I left a comment that you might want to look at
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
…s versions 11 and 12
706ed44
to
1ef4341
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
What this PR does / why we need it:
Changes to the npm packages structure has caused 404s in the eslint plugin download paths. This PR should address errors such as:
It also fixes the issue where the packages declarations are split across multiple files (>=12.1.0) by using npm install instead of attempting to download a single d.ts file from the cdn.
Which issue(s) this PR fixes:
Fixes #2210
Special notes for your reviewer:
📦 Published PR as canary version:
Canary Versions
✨ Test out this PR locally via:
npm install @grafana/eslint-plugin-plugins@0.5.1-canary.2208.18380752954.0 npm install @grafana/plugin-e2e@2.2.2-canary.2208.18380752954.0 # or yarn add @grafana/eslint-plugin-plugins@0.5.1-canary.2208.18380752954.0 yarn add @grafana/plugin-e2e@2.2.2-canary.2208.18380752954.0