Serverless aws deploy #1338
Serverless aws deploy #1338
Conversation
zalegrala
force-pushed
the
serverlessAwsDeploy
branch
5 times, most recently
from
76989e4
to
e5820f2
Compare
| @@ -25,18 +25,6 @@ build-gcf-zip: | |||
| $(IN_CLOUD_FUNCTIONS) zip tempo-serverless-$(VERSION).zip ./* -r | |||
| $(IN_CLOUD_FUNCTIONS) rm -rf vendor | |||
|
|
|||
| # | |||
There was a problem hiding this comment.
we need some way to build the docker image from the makefile. also we should clean up build-lambda-zip if we don't intend to use it anymore.
There was a problem hiding this comment.
The docker build for lambda has been moved to the root Makefile, but I was leaving build-lambda-zip in place while the #1347 is in flight.
Makefile
Outdated
| @@ -55,6 +55,10 @@ tempo-cli: | |||
| tempo-vulture: | |||
| GO111MODULE=on CGO_ENABLED=0 go build $(GO_OPT) -o ./bin/$(GOOS)/tempo-vulture-$(GOARCH) $(BUILD_INFO) ./cmd/tempo-vulture | |||
|
|
|||
| .PHONY: tempo-serverless/lambda | |||
There was a problem hiding this comment.
we should have a way to build all of the serverless stuff in the cmd/tempo-serverless makefile. having some commands there and some here is messy.
also there is already a ### serverless section these could go in. i'm not married to it, but we need to organize ourselves somehow.
There was a problem hiding this comment.
I agree we'll want to organize, and I'd favor this file over the nested one if we can. I'm mostly paying attention to the AWS bits currently because it seems more easily workable into our existing CI.
| @@ -0,0 +1,44 @@ | |||
| # | |||
There was a problem hiding this comment.
if this is intended to be a proxy image only we could clean it up quite a bit. there's no need to put the lambda binary in here.
also, i'm not seeing changes to the e2e tests?
There was a problem hiding this comment.
I'll be looking at cleaning up the proxy file, and maybe relocating it. I'm thinking we want to produce a proxy docker image for the e2e environment.
| FROM alpine:3.9 as certs |
There was a problem hiding this comment.
does this work? doesn't a custom docker image require specific base images? or some kind of lambda runtime?
There was a problem hiding this comment.
I think this will come up in the testing. I believe you might be right though if we want to test outside of AWS, we need to have the proper environment variables in place.
|
Also note that you'll need to update the docs merged here: |
zalegrala
force-pushed
the
serverlessAwsDeploy
branch
from
445e2e2
to
b2706f2
Compare
zalegrala
force-pushed
the
serverlessAwsDeploy
branch
from
6a22d6a
to
b1f1cd0
Compare
|
I prefer #1357 for the e2e parts, and for deploy, I'll follow up with the s3 approach. Building out the docker image as I attempted here doesn't gain us anything over the s3 approach in that it won't be able to provide an image for the community to use, since users will need to copy this to their own ecr repo, which has slightly more complexity than the bucket + access approach we can take with s3. |
What this PR does:
Here we a to build the serverless components for AWS lambda with the main tempo build.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]