Make NavigableMap deprecation message easier to follow #12135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the deprecation of NavigableMap the logs are filled with lines suggesting not to use it, but it can be hard to track down exactly _where_ the usage was invoked. This change intends to give users a clue as to where the usage is such that they can fix it before the feature is removed
puneetbehl
approved these changes
Oct 14, 2021
andrewcanby-finocomp
deleted the
informative-navigablemap-deprecation-message
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the deprecation of NavigableMap the logs are filled with lines suggesting not to use it, but it can be hard to track down exactly where the usage was invoked.
This change intends to give users a clue as to where the usage is such that they can fix it before the feature is removed.
Before:
After:
This does not print out the whole config key, only the key of the currently dereferenced item.