Grails Engineering Meeting Notes (10 29 2020)
Puneet Behl edited this page Oct 29, 2020
·
3 revisions
Date: 10/29/2020
- Puneet Behl
- James Kleeh
- Iván López
- Jason Schindler
- Current Grails Development Activities
- Multipart resolver exception handling
- Collection url mapping inside a group
- Grails 4 reloading problems with Micronaut classes as the Introspected classes are not updated upon recompile.
- Open Discussion
- Released Grails 4.0.5 last week
- Updated Micronaut, Spring, SpringBoot, GORM dependencies
- Release notes in Grails Core
- Do you think I need to follow the same path for updating dependencies going through views and gsp first?
- James: Assuming the release is backwards compatible, you should be able to do core first
- Puneet: Do you know if Spring follows semantic versioning?
- James: I'm not sure what they follow
- Also work on updating dependencies for 4.1 M3
- Triaging issues
- Puneet: When you have a custom method interceptor in Grails code, it doesn't work correctly with Micronaut because it doesn't pass the classloader
- Puneet: I submitted a PR to Micronaut for this fix
- James: I saw it but haven't reviewed yet
- Puneet: Once that is fixed in Micronaut we'll be able to fix this in Grails 4.1
- https://github.com/grails/grails-core/pull/10922
- Ivan: This was a breaking change I submitted about 2 years ago. If you open the issue you see that the search endpoint is not the right one. Fixing that will break anything that was using the old search endpoint
- James: If we are going to merge this in we will need to add some documentation explaining the change
- Puneet: I think this might have been fixed in Groovy 3 or become more complicated but we need to test.
- Puneet: Can you take a look at this with latest Grails 4 release and see if it is still a problem and update the docs?
- Ivan: Yes, I can
- https://github.com/grails/grails-core/issues/10928
- Puneet: In the issue about Multipart resolver exception handling not working, there is a comment that says "The issue is not setting the max size, the problem is gracefully managing the exception when the max size is reached" Is that something that we have to handle in Grails?
- James: The goal was to be able to return something to the user saying that the file has exceeded the limit and it doesn't execute your application code when that happens so there is no way for you to return the exception
- James: The idea was to replace standard multi-part resolver and change its behavior, but it seems like even if you changed that it still wouldn't work.
- James: It is an old issue. There could have been changes in Spring Boot since that time that handles this
- Puneet: I'll take a look at it for the 4.0.6 milestone
-
James: Are you expecting any more breaking changes in the 4.1.x line?
- Puneet: Yes due to some Spring updates that I think removed some classes
- Puneet: Also updating to Micronaut 2.1
-
James: If you aren't expecting any more breaking changes after this release, you can do an RC instead of M3
- Puneet: I'll take a look closer to release to see what the potential breaking changes are