fix: emit new events in AuthorizedCollector and TokensRescued. (OZ N-14) #1049
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…okensRescued respectively.
fix: emit new events in AuthorizedCollector and TokensRescued. (OZ N-14)
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
MoonBoi9001
changed the title
commit to now emit both the amount for which the collector was authorized and also the total amount for which they are now authorized
tmigone
requested changes
Oct 2, 2024
packages/horizon/contracts/data-service/interfaces/IDataServiceRescuable.sol
Outdated
Show resolved
Hide resolved
…eRescuable.sol Co-authored-by: Tomás Migone <tomas@edgeandnode.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Title:
N-14 Event Emission Suggestions
Details:
Throughout the codebase, multiple instances of events that could emit additional information were identified:
The AuthorizedCollector event could emit the amount for which the collector was authorized.
The TokensRescued event could emit the token that was rescued.
Consider updating these events to enhance off-chain tracking and ensure comprehensive event logging.
Key changes