Skip to content

Conversation

RembrandtK
Copy link
Contributor

@RembrandtK RembrandtK commented Oct 3, 2025

Removing dev container config from the repo for now.

Although in the long term it would be good to have a dev container configuration, currently:

  1. AFAIK I am the only one using it.
  2. The current config has dependencies on local setup and mixes repo concerns and personal preferences. This might be resolved as the config evolves, but anyone else would currently not have a great experience (due to dependencies and the rate of change).
  3. The config is evolving though ongoing tweaks while I work on other items causes friction due to needing to patch multiple branches.

I am still using dev containers but my local setup now associates dev container configs with repos without touching the repo itself. This works well for me, while avoiding dependencies on repo configuration.

A dev container configuration might well be re-introduced in future when more stable. In the meantime if you would like to use dev containers let me know, and can share my config and approach, and potentially (if ready) add a config back if ready.

@RembrandtK RembrandtK self-assigned this Oct 3, 2025
@RembrandtK RembrandtK requested a review from Copilot October 3, 2025 15:33
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the dev container configuration from the repository based on the maintainer's assessment that it's not ready for general use and creates maintenance friction. The config has dependencies on local setup, mixes personal preferences with repo concerns, and is actively evolving in ways that require patching across multiple branches.

  • Removes all dev container configuration files from the .devcontainer/ directory
  • Eliminates Docker and Docker Compose setup files
  • Removes shell scripts for project and host setup
  • Clears documentation and sample environment files

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
.devcontainer/setup-git-signing.sh Removes SSH signing setup script
.devcontainer/sample-graph.env Removes sample environment configuration
.devcontainer/project-setup.sh Removes project-specific setup script
.devcontainer/host-setup.sh Removes host environment setup script
.devcontainer/docker-compose.yml Removes Docker Compose service definition
.devcontainer/devcontainer.json Removes VS Code dev container configuration
.devcontainer/README.md Removes dev container documentation
.devcontainer/Dockerfile Removes container image definition

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

codecov bot commented Oct 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.84%. Comparing base (cd59452) to head (b7ca26d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1231   +/-   ##
=======================================
  Coverage   82.84%   82.84%           
=======================================
  Files          47       47           
  Lines        2093     2093           
  Branches      620      620           
=======================================
  Hits         1734     1734           
  Misses        359      359           
Flag Coverage Δ
unittests 82.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@RembrandtK RembrandtK marked this pull request as ready for review October 3, 2025 15:54
@RembrandtK RembrandtK merged commit 2f3fdb8 into main Oct 6, 2025
6 checks passed
@RembrandtK RembrandtK deleted the remove-devcontainer branch October 6, 2025 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants