Skip to content

Update to Solidity 6.4 #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 19, 2020
Merged

Update to Solidity 6.4 #165

merged 1 commit into from
Mar 19, 2020

Conversation

abarmat
Copy link
Contributor

@abarmat abarmat commented Mar 18, 2020 •
edited
Loading

This PR upgrades the compiler to use the latest version of Solidity.

This PR branches from #164 please merge that one first.

All the tests are passing ✅

Doing this upgrade meant:

  1. Fixing the Gnosis MultisigWallet as I could not find an already ported version. (just small changes)
  2. Bumping to OpenZeppelin v3 for use in GraphToken.
  3. Implementing ERC20Minting in GraphToken as for some reason was removed in Zeppelin.

Notes:

  • We can use the latest Multisig available at the moment we launch the network.

@Zerim

@abarmat abarmat requested a review from davekay100 March 18, 2020 21:39
@abarmat abarmat self-assigned this Mar 18, 2020
@abarmat abarmat requested a review from Zerim March 18, 2020 21:40
@abarmat abarmat mentioned this pull request Mar 18, 2020
Merged
davekay100
davekay100 approved these changes Mar 19, 2020
View reviewed changes
Copy link
Contributor

@davekay100 davekay100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@abarmat abarmat merged commit e47922d into master Mar 19, 2020
@abarmat abarmat deleted the chore/solidity-6 branch March 19, 2020 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zerim Zerim Awaiting requested review from Zerim

1 more reviewer

@davekay100 davekay100 davekay100 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@abarmat abarmat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abarmat @davekay100