build: add husky rules #178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note:
I would like to left both flattening and ABI extraction for a CI task that export them to an NPM package. |
davekay100
approved these changes
Apr 29, 2020
abarmat
added a commit
that referenced
this pull request
May 4, 2020
* stlye: increase max line * tests: remove unused test * curation: refactor and natspec update * disputes: update reward calculation and natspec * tests: remove unused and add new defaults * staking: rewrite first version with stake+allocate * staking: add channel data * staking: fix test * staking: add thawing period * staking: add token locking for withdrawal * staking: - add "low-level" stake balance logic in a library - add and improve stake, unstake, allocate, slash functions - add withdraw unlocked tokens after thawing period - add support for thawing averaging when multiple unstake request - move slashingPercent settings and calculations to dispute contract * staking: add tests * staking: add more test * staking: add unstake weighted avg tests * tests: equal -> eq * staking: add more tests * curation: rename functions * staking: add channel multisig creation * staking: channel settlement according to incoming token address * staking: - use underscore for private methods as convention - actually create the conterfactual multisig channel - fix tests * staking: add rebate pool * staking: avoid distribution of curation fees if subgraph not curated * build: fix and improve deploy script (#175) * build: - deploy script using await/async - deploy missing new contracts - add a config file with desired deploy parameters * build: remove web3 dependency in config file * build: add tx hash when calling setters and better logging * staking: remove channel proxy channel creation in favor of tracking channels by index node signer address * staking: delete rebate pool when all settlements claimed * staking: add channelDisputePeriod * staking: - allow max settlement to be zero - add event for rebate claim - setter for curation * staking: allow to restake when claiming the rebate * staking: do not allow to slash more funds than staked * staking: add channel dispute period restriction to claim * staking: check condition to avoid unstaking more funds that exist at the moment of withdrawal * staking: remove unallocate public call (for now) as only way to unallocate from subgraph must be to settle * disputes: chain id (#176) * staking: add more comments * epochs: remove unused redundant block number data (#177) * build: add husky rules (#178) * build: add husky rule for push * build: add husky config file * build: husky lint-staged * build: setup husky in package.json * build: process un-prettyfied files * staking: add setter for curation fee percentage and more tests * staking: address review improvements * staking: remove unused import * staking: rename index node stake tokens to make it clearer * staking: remove totalTokens and totalFees unused state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds running a lint and test script when pushing