Skip to content

Conversation

abarmat
Copy link
Contributor

@abarmat abarmat commented May 21, 2020

Advertise, in the AllocationCreated event, the non-binding price charged for queries related to an allocation.

@abarmat abarmat requested a review from davekay100 May 21, 2020 20:14
@abarmat
Copy link
Contributor Author

abarmat commented May 21, 2020

@davekaj this is the one that adds price to the event

@abarmat abarmat self-assigned this May 21, 2020
@abarmat abarmat changed the base branch from master to ariel/staking-tests-1 May 23, 2020 23:59
@abarmat abarmat force-pushed the ariel/staking-tests-1 branch 2 times, most recently from c309d50 to f2140ad Compare May 25, 2020 16:01
@abarmat abarmat force-pushed the ariel/staking-alloc-price branch from b19097d to 8fd98c0 Compare May 25, 2020 16:30
@abarmat
Copy link
Contributor Author

abarmat commented May 25, 2020

Rebased

Base automatically changed from ariel/staking-tests-1 to master May 25, 2020 19:04
…rice charged for queries related to an allocation
@abarmat abarmat force-pushed the ariel/staking-alloc-price branch from 8fd98c0 to 48cd1da Compare May 25, 2020 19:08
Copy link
Contributor

@davekay100 davekay100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

* staking: validate settle caller is the channel multisig proxy
* disputes: fix and improve tests
@abarmat abarmat merged commit 1c8cc05 into master May 28, 2020
@abarmat abarmat deleted the ariel/staking-alloc-price branch May 28, 2020 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants