curation: use curation signal #246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davekay100
approved these changes
Jul 15, 2020
| // Amount of shares you get with your minimum token stake | ||
| uint256 private constant SHARES_PER_MINIMUM_STAKE = 1 ether; | ||
| // Amount of signal you get with your minimum token stake | ||
| uint256 private constant SIGNAL_PER_MINIMUM_STAKE = 1 ether; | ||
|
|
||
| // -- Events -- | ||
|
|
||
| /** | ||
| * @dev Emitted when `curator` staked `tokens` on `subgraphDeploymentID` as curation signal. |
There was a problem hiding this comment.
I believe we might what to also change staked to signaled everywhere - and essentially remove the word from any code that interacts with curation.
I think what we want is:
Indexer
- verb = stake
- noun = stake
Curator
- verb = signal
- noun = signal
But right now I think we have it as:
Curator
- verb = stake
- noun = signal
Let me post in slack and see if brandon agrees, I seem to remember him saying this, but I am unsure
|
@davekaj I updated the verbs |
davekay100
approved these changes
Jul 16, 2020
abarmat
force-pushed
the
ariel/curation-signal
branch
from
a94ad84 to
768c9b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use signal as verb and to represent a portion of CurationPool.