epochs: make epoch manager upgradeable #256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abarmat
changed the base branch from
master
to
ariel/staking-default-delegation-params
davekay100
approved these changes
Jul 22, 2020
We don't have specific test for the GraphProxy I'm planning to add some when I tackle an improvements I want to do to use a fixed SLOT for the implementation address. EIP-1967 https://eips.ethereum.org/EIPS/eip-1967 Even if we don't have specific tests for that part, all the tests now are setup using Proxies for the upgradeable contracts, so they are being tested indirectly. |
Base automatically changed from
ariel/staking-default-delegation-params
to
master
July 22, 2020 18:45
abarmat
force-pushed
the
ariel/upgrade-epochmanager
branch
from
1c4e21b to
7e8b857
Compare
|
Rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.