Cache address resolution from the Controller #430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abarmat
changed the title
davekay100
suggested changes
Dec 10, 2020
There was a problem hiding this comment.
Requesting changes so it is unmergable for now, as #435 is the solution for launch
abarmat
changed the title
abarmat
force-pushed
the
ariel/address-cache
branch
from
090baf9 to
6f68ce9
Compare
|
Audited tag + fixes: https://github.com/graphprotocol/contracts/releases/tag/audit%2Fpr-430 |
abarmat
added a commit
that referenced
this pull request
May 17, 2021
Having a Controller contract is great in that we can sync addresses across the protocol from a single place, but it involves a roundtrip of CALL opcodes to get the addresses each time they are used. This change creates a local cache within each contract to store the list of contract addresses and refresh it when the Controller changes any contract address. This mechanism relies on an external party calling the `syncAllContracts` function.
abarmat
added a commit
that referenced
this pull request
May 17, 2021
Having a Controller contract is great in that we can sync addresses across the protocol from a single place, but it involves a roundtrip of CALL opcodes to get the addresses each time they are used. This change creates a local cache within each contract to store the list of contract addresses and refresh it when the Controller changes any contract address. This mechanism relies on an external party calling the `syncAllContracts` function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is saving between 5% to 15% gas depending on the transaction.
Related to: #433