Disputes with separate slashing percentages for queries and indexing #458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abarmat
force-pushed
the
ariel/separate-slashing-percentages
branch
from
30929a5 to
b61a9b2
Compare
…would fail under certain conditions and that best course of action is to resolve using draw or reject
|
Audited tag + fixes: https://github.com/graphprotocol/contracts/releases/tag/audit%2Fpr-458 |
abarmat
added a commit
that referenced
this pull request
May 17, 2021
…458) Adds a different slashing percentage for Indexing Disputes and Query Disputes - Add a type to the dispute to categorize it when someone creates it. - Create new storage var for a separate indexer and query slashing percentages. - Add setters for each new slashing governance variable. - Pick the right slashing percentage when the dispute is resolved. - Additional minor refactors.
abarmat
added a commit
that referenced
this pull request
May 17, 2021
…458) Adds a different slashing percentage for Indexing Disputes and Query Disputes - Add a type to the dispute to categorize it when someone creates it. - Create new storage var for a separate indexer and query slashing percentages. - Add setters for each new slashing governance variable. - Pick the right slashing percentage when the dispute is resolved. - Additional minor refactors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The DisputeManager is the contract where actors in the protocol can create disputes about indexers misbehaving. There are two types of disputes: indexing and query ones. Indexing disputes are created based on one allocation that was closed with a wrong POI (proof of indexing) while query disputes are created presenting an attestation for a wrong query returned. After a dispute is created, the Arbitrator can resolve it and slash a percentage of the indexer's stake.
The PR adds a different slashing percentage for Indexing Disputes and Query Disputes.
Motivation
The current contract uses the same slashing percentage for indexing and query disputes. However, more flexibility is desirable as one indexing offense can carry much more weight than a single bad query returned. Having a too high slashing percentage for a single wrong query can be a disincentive for indexers to serve queries.
Solution