Change the way blocks are mined during testing #554
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #517, our hardhat local network mines blocks in two ways:
I suspect this is breaking our unit tests for a few reasons:
This PR changes things in two ways:
I've run
yarn test
several times in this branch and haven't seen it fail so far (whereas it often fails if I run it from the main dev branch).An additional small change: we allow passing file paths to
yarn test
so that we can optionally run only specific testfiles.