Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add GRE test to GitHub actions #706

Merged
merged 2 commits into from
Sep 7, 2022
Merged

chore: add GRE test to GitHub actions #706

merged 2 commits into from
Sep 7, 2022

Conversation

tmigone
Copy link
Contributor

@tmigone tmigone commented Sep 6, 2022

Changes

  • Run yarn test:gre when merging to dev.
  • Fix a bug in GRE tests where test env was picking up project's main hardhat.config.ts file instead of a test one due to incorrect file extension (.js --> .ts)

Signed-off-by: Tomás Migone tomas@edgeandnode.com

Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
@codecov
Copy link

codecov bot commented Sep 6, 2022

Codecov Report

Merging #706 (53af9db) into dev (455aa4e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #706   +/-   ##
=======================================
  Coverage   90.57%   90.57%           
=======================================
  Files          35       35           
  Lines        1762     1762           
  Branches      296      296           
=======================================
  Hits         1596     1596           
  Misses        166      166           
Flag Coverage Δ
unittests 90.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@pcarranzav pcarranzav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmigone tmigone merged commit af17480 into dev Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants