Skip to content

fix: send to l2 task incorrectly setting sender #922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 16, 2024
Merged

fix: send to l2 task incorrectly setting sender #922

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
819a8ae
fix: send to l2 task incorrectly setting sender
tmigone Jan 16, 2024
67eaac8
chore: document sender requirements on send to l2 task
tmigone Jan 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions packages/contracts/tasks/bridge/to-l2.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,10 @@ import { SignerWithAddress } from '@nomiclabs/hardhat-ethers/signers'

greTask('bridge:send-to-l2', 'Bridge GRT tokens from L1 to L2')
.addParam('amount', 'Amount of tokens to bridge')
.addOptionalParam('sender', 'Address of the sender. L1 deployer if empty.')
.addOptionalParam(
'sender',
'Address of the sender, must be managed by the provider node. L1 deployer if empty.',
)
.addOptionalParam('recipient', 'Receiving address in L2. Same to L1 address if empty.')
.addOptionalParam(
'deploymentFile',
Expand All @@ -22,14 +25,10 @@ greTask('bridge:send-to-l2', 'Bridge GRT tokens from L1 to L2')
}

// Get the sender, use L1 deployer if not provided
const l1Deployer = await graph.l1.getDeployer()
const sender: string = taskArgs.sender ?? l1Deployer.address

const signer = await SignerWithAddress.create(graph.l1.provider.getSigner(sender))
if (!signer) {
throw new Error(`No wallet found for address ${sender}`)
}
console.log(`> Using wallet ${signer.address}`)
const sender = taskArgs.sender
? await SignerWithAddress.create(graph.l1.provider.getSigner(taskArgs.sender))
: await graph.l1.getDeployer()
console.log(`> Using wallet ${sender.address}`)

// Patch sendToL2 opts
taskArgs.l2Provider = graph.l2.provider
Expand All @@ -40,7 +39,7 @@ greTask('bridge:send-to-l2', 'Bridge GRT tokens from L1 to L2')
taskArgs.maxGas = BigNumber.from('400000')
}

await sendToL2(graph.contracts, signer, {
await sendToL2(graph.contracts, sender, {
l2Provider: graph.l2.provider,
amount: taskArgs.amount,
recipient: taskArgs.recipient,
Expand Down