fix: change pending rewards due to resize to token amounts instead of per token (OZ H-01) #993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: change pending rewards due to resize to token amounts instead of per token (OZ H-01)
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
tmigone
changed the title
Maikol
approved these changes
Aug 15, 2024
tmigone
force-pushed
the
mde/pr991-fix-oz-c-05
branch
from
d546750 to
0412587
Compare
tmigone
force-pushed
the
tmigone/horizon-h01-rewards-inflation
branch
from
530f88e to
fd370d0
Compare
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
|
tmigone
force-pushed
the
mde/pr991-fix-oz-c-05
branch
from
0412587 to
c783118
Compare
… per token (OZ-H01) Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
tmigone
force-pushed
the
tmigone/horizon-h01-rewards-inflation
branch
from
fd370d0 to
7726b58
Compare
pcarranzav
reviewed
Aug 22, 2024
| @@ -10,13 +10,20 @@ interface IRewardsIssuer { | |||
| * @return subgraphDeploymentId Subgraph deployment id for the allocation | |||
| * @return tokens Amount of allocated tokens | |||
| * @return accRewardsPerAllocatedToken Rewards snapshot | |||
| * @return accRewardsPending Tokens pending to be claimed | |||
There was a problem hiding this comment.
nit: the description here isn't super clear. Maybe something like "Snapshot of accumulated rewards from previous allocation resizing, pending to be claimed"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.