Update dependencies + tweaks #462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benface
commented
Aug 9, 2023
Comment on lines
+131
to
+136
| title: `${title ? `${title} | ` : ''}Docs | The Graph`, | ||
| description: frontMatter.description, | ||
| openGraph: { | ||
| title, | ||
| images: frontMatter.socialImage ? [{ url: frontMatter.socialImage }] : undefined, | ||
| }, |
There was a problem hiding this comment.
Simpler + makes titles consistent with graph-website (i.e. {pageTitle} | {sectionTitle} | The Graph for <title>, and just pageTitle for og:title)
benface
commented
Aug 9, 2023
| @@ -65,8 +65,6 @@ Failing to follow the above rules will end with an error from the Graph API. | |||
|
|
|||
| For a complete list of rules with code examples, please look at our GraphQL Validations guide. | |||
|
|
|||
| <br /> | |||
There was a problem hiding this comment.
The extra spacing looks weird IMO; I think we should be consistent with spacing.
benface
commented
Aug 9, 2023
| "@types/react-dom": "^18.2.7", | ||
| "next": "^13.4.12", | ||
| "next": "13.4.12", |
There was a problem hiding this comment.
There's an issue with Next 13.4.13, so locking the version for now.
📦 Next.js Bundle Analysis for @graphprotocol/docsThis analysis was generated by the Next.js Bundle Analysis action. 🤖 🎉 Global Bundle Size Decreased
DetailsThe global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster. Any third party scripts you have added directly to your app using the If you want further insight into what is behind the changes, give @next/bundle-analyzer a try! Seven Hundred Fifteen Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored. |
dimaMachina
reviewed
Aug 9, 2023
dimaMachina
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This notably removes MIPs from the global navigation (under "Ecosystem").